feat: update insta inline snapshot when clicking 'Update Test' runnable #19197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
andylokandy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Update Test' runnable was implemented in PR #18757.
It was found that the
instasnapshot library does not update inline snapshots using the 'Update Test' runnable because it only sets the environment variableINSTA_UPDATE=alwayswhich does not affect inline snapshots.instasupports updating snapshots usingcargo-nextest, which run each test in a single process, requiring the external toolcargo-instato collect diffs and apply changes. Thus, updating inline snapshots with plaincargo testis not feasible(insta #490).This PR changes the 'Update Test' runnables to use
cargo insta testinstead ofcargo test ...when the test involvesinsta. This change is justified sincecargo insta testis compatible with other snapshot libraries and it is assumed thatinstausers havecargo-instainstalled.