internal: Migrate apply_demorgan to SyntaxEditor
#19171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
commented
Feb 18, 2025
| /// Take all of the tracked syntax mappings, leaving `SyntaxMapping::default()` in its place, if any. | ||
| pub fn take(&self) -> SyntaxMapping { | ||
| self.mappings.as_ref().map(|mappings| mappings.take()).unwrap_or_default() | ||
| } |
There was a problem hiding this comment.
We have many assists that need to capture the reference to SyntaxEditor into the closures that feeded into iterators, and once we do so, we cannot use its SyntaxMappings forever.
I tried this dance but while working on other assists, I found that there are many assists that require it, so instead of it, I'm adding this new method.
Veykril
approved these changes
Feb 24, 2025
| @@ -214,6 +330,21 @@ impl SyntaxFactory { | |||
| make::expr_empty_block().clone_for_update() | |||
| } | |||
|
|
|||
| pub fn expr_paren(&self, expr: ast::Expr) -> ast::ParenExpr { | |||
| // FIXME: `make::expr_paren` should return a `MethodCallExpr`, not just an `Expr` | |||
There was a problem hiding this comment.
Suggested change
| // FIXME: `make::expr_paren` should return a `MethodCallExpr`, not just an `Expr` | |
| // FIXME: `make::expr_paren` should return a `ParenExpr`, not just an `Expr` |
ShoyuVanilla
force-pushed
the
migrate-de-morgan-assist
branch
from
6a528d5 to
a0b9931
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18285