Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Spawn toolchain querying processes in parallel #19142

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 12, 2025

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2025
@Veykril
Copy link
Member Author

Veykril commented Feb 12, 2025

r? @davidbarsky

Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, modulo nits

@@ -34,14 +34,14 @@ pub struct Sysroot {
}

#[derive(Debug, Clone, Eq, PartialEq)]
pub(crate) enum SysrootWorkspace {
pub enum SysrootWorkspace {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, should this be renamed to RustSrc, since this isn't the sysroot per-se, but rather a component in a sysroot called rust-src?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed things

@Veykril Veykril enabled auto-merge February 12, 2025 15:55
@Veykril Veykril added this pull request to the merge queue Feb 12, 2025
Merged via the queue into rust-lang:master with commit c661e5e Feb 12, 2025
9 checks passed
@Veykril Veykril deleted the push-upwqztrsuwpz branch February 12, 2025 16:20
@lnicola lnicola changed the title Spawn toolchain querying processes in parallel internal: Spawn toolchain querying processes in parallel Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants