fix: Don't emit empty scip occurrence for builtins #19105
Merged
+31
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Feb 7, 2025
|
We could maybe point the primitive types to their core re-exports https://doc.rust-lang.org/src/core/primitive.rs.html or rustdoc module shims https://doc.rust-lang.org/src/core/primitive_docs.rs.html |
|
I feel like the rustdoc module shims would be more useful for users, but I don't feel too strongly. |
facebook-github-bot
pushed a commit
to facebookincubator/Glean
that referenced
this pull request
Mar 17, 2025
Summary: rust-analyzer had a bug which caused it to emit empty symbol occurrences (occurrences without a `symbol` field). I fixed this upstream, but we haven't upgrade rust-analyzer internally yet: rust-lang/rust-analyzer#19105. This diff makes scip_to_glean behave the same as the [Haskell](https://www.internalfb.com/code/fbsource/[e9004f2932c4d2c96272dc586a3b2a431ac08a5e]/fbcode/glean/lang/scip/Data/SCIP/Angle.hs?lines=439) implementation in the presence of these erroneous occurrences. Reviewed By: donsbot Differential Revision: D71346020 fbshipit-source-id: 751d5b8f117e8418c1637b3196bee252b69f56c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently emit occurrences without a symbol name (e.g.,
{ "range": [ 1, 7, 10 ] }) for builtins (e.g.,i64). This happens becauseide::moniker::def_to_monikerreturnsNonefor builtins:rust-analyzer/crates/ide/src/moniker.rs
Lines 253 to 257 in ca47cdd
It never makes sense to emit an occurrence without a symbol name, so just skip in that case.