fix: Fix scip indexing of module names #19062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
darichey
force-pushed
the
scip-fix-module-names
branch
from
e6be538 to
9462322
Compare
Veykril
approved these changes
Jan 28, 2025
auto-merge was automatically disabled
January 28, 2025 16:44
Head branch was pushed to by a user without write access
|
This also affects LSIF output. The changes look reasonable, but I don't know how to verify they are correct. cc @Urhengulas |
|
or @Veykril since you added the final version of the lsif_contains_generated_constant test. |
Veykril
approved these changes
Feb 3, 2025
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_inherent_impl(moniker.identifier.description.len() - 2). No behavior change, just annoying when trying to debug.crate. Where we previously emitted, e.g.,{ "range": [ 5, 4, 9 ] }, we will now emit{ "range": [ 5, 4, 9 ], "symbol": "rust-analyzer cargo foo . crate/" }.