Skip to content

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Apr 21, 2024

With this, script files become more usable as the user can at least add them manually to the linked projects, allowing them to be used "on the (manual) fly" without having to open a separate vscode window that only has files open and no folder.

Also makes build scripts work for them (including proc-macros)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2024
@Veykril
Copy link
Member Author

Veykril commented Apr 21, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 21, 2024

📌 Commit af3fc73 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 21, 2024

⌛ Testing commit af3fc73 with merge 1948d46...

bors added a commit that referenced this pull request Apr 21, 2024
feat: Allow rust files to be used linkedProjects

With this, script files become more usable as the user can at least add them manually to the linked projects, allowing them to be used "on the (manual) fly" without having to open a separate vscode window that only has files open and no folder.

Also makes build scripts work for them (though no proc-macros, for some reason the dylib field is not populated in the output)
@bors
Copy link
Contributor

bors commented Apr 21, 2024

💔 Test failed - checks-actions

@Veykril Veykril force-pushed the linked-rust-files branch from af3fc73 to e83cab2 Compare April 21, 2024 14:18
@Veykril Veykril force-pushed the linked-rust-files branch from e83cab2 to a2ed683 Compare April 21, 2024 14:26
@Veykril
Copy link
Member Author

Veykril commented Apr 21, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 21, 2024

📌 Commit a2ed683 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 21, 2024

⌛ Testing commit a2ed683 with merge f512a5e...

@bors
Copy link
Contributor

bors commented Apr 21, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing f512a5e to master...

@bors bors merged commit f512a5e into rust-lang:master Apr 21, 2024
@Veykril Veykril deleted the linked-rust-files branch April 21, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants