feat: preview adt field when hover #15847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Member
|
Nit: we should probably match the standard Rust formatting ( |
lnicola
reviewed
Nov 7, 2023
lnicola
approved these changes
Nov 7, 2023
Contributor
Author
Sure. Fixes have been pushed. |
wasd96040501
force-pushed
the
feat/preview_adt
branch
from
bc0578f to
46af7d3
Compare
lnicola
reviewed
Nov 8, 2023
Member
|
Unrelated, let's test this little thing: @bors2 try |
Member
|
@bors2 try |
rust-bors-staging bot
added a commit
that referenced
this pull request
Nov 8, 2023
feat: preview adt field when hover Closes #13977 
lnicola
reviewed
Nov 8, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
Thanks, would you mind squashing? |
wasd96040501
force-pushed
the
feat/preview_adt
branch
from
cccd8e7 to
41bcd54
Compare
Contributor
Author
Sure, already squashed. |
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Member
|
Related #3197, that is we might want to do something similar for enum (variants). |
Member
|
I think we might want to expose a config for this, to enable, disable and maybe set a maximum field amount to render? Unsure, will probably see after having used this a bit. |
bors
added a commit
that referenced
this pull request
Mar 5, 2024
…eykril feat: add hover display for trait assoc items This PR enable preview assoc items when hover on `trait`  inspired by #15847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13977
