Don't suggest unnameable generic arguments #99580
Merged
+90
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
Contributor
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
Collaborator
|
Some changes occurred in need_type_info.rs cc @lcnr |
rust-highfive
added
the
S-waiting-on-review
fmease
commented
Jul 22, 2022
fmease
commented
Jul 22, 2022
compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs
Outdated
Show resolved
Hide resolved
fmease
commented
Jul 22, 2022
compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Several minor diagnostic regressions. Not sure how to fix them. |
compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs
Outdated
Show resolved
Hide resolved
Member
Author
|
I've applied your feedback which has also resolved those diagnostic regressions! :) |
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 23, 2022
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#99580 (Don't suggest unnameable generic arguments) - rust-lang#99617 (Update mdbook) - rust-lang#99631 (Use span_bug in case of unexpected rib kind) - rust-lang#99632 (Fix typo/grammar in locator.rs doc comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99565.
@rustbot label T-compiler A-diagnostics
r? @rust-lang/wg-diagnostics