Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Try using call-site aware IR PGO for LLVM #97153

Closed
wants to merge 2 commits into from
Closed

[WIP] Try using call-site aware IR PGO for LLVM #97153

wants to merge 2 commits into from

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 18, 2022

LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works.

r? @ghost

@Kobzol
Copy link
Contributor Author

Kobzol commented May 18, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 18, 2022
@bors
Copy link
Collaborator

bors commented May 18, 2022

⌛ Trying commit 15da36b487fb82d429209e0a4e08ad57981be4c1 with merge 8851e36fefe79fb0e7ceac2986b07bcf5e534835...

@bors
Copy link
Collaborator

bors commented May 18, 2022

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 18, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Contributor Author

Kobzol commented May 19, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented May 19, 2022

⌛ Trying commit d183f765a21b7928379d815cea11e481c20050b2 with merge 87302328f42a41865f79dd5d01857803704966db...

@bors
Copy link
Collaborator

bors commented May 19, 2022

☀️ Try build successful - checks-actions
Build commit: 87302328f42a41865f79dd5d01857803704966db (87302328f42a41865f79dd5d01857803704966db)

@rust-timer
Copy link
Collaborator

Queued 87302328f42a41865f79dd5d01857803704966db with parent c067287, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (87302328f42a41865f79dd5d01857803704966db): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 124 82 0 0 124
mean2 7.6% 6.0% N/A N/A 7.6%
max 18.1% 16.6% N/A N/A 18.1%

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 231 256 1 0 232
mean2 6.6% 10.8% -1.1% N/A 6.6%
max 22.8% 25.1% -1.1% N/A 22.8%

Cycles

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 100 75 1 0 101
mean2 12.3% 9.2% -1.7% N/A 12.1%
max 23.5% 26.5% -1.7% N/A 23.5%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. number of relevant changes ↩ ↩2 ↩3

  2. the arithmetic mean of the percent change ↩ ↩2 ↩3

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 19, 2022
@Kobzol
Copy link
Contributor Author

Kobzol commented May 20, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 20, 2022
@bors
Copy link
Collaborator

bors commented May 20, 2022

⌛ Trying commit 3736e6b044b5e07c156ef77dc2e5f3dd8759e733 with merge cbed134b20d1fe82e1106f135cc4383f4021933b...

@bors
Copy link
Collaborator

bors commented May 20, 2022

☀️ Try build successful - checks-actions
Build commit: cbed134b20d1fe82e1106f135cc4383f4021933b (cbed134b20d1fe82e1106f135cc4383f4021933b)

@rust-timer
Copy link
Collaborator

Queued cbed134b20d1fe82e1106f135cc4383f4021933b with parent b5caa5a, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cbed134b20d1fe82e1106f135cc4383f4021933b): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 5 14 0 1 5
mean2 1.3% 1.4% N/A -3.5% 1.3%
max 1.5% 2.2% N/A -3.5% 1.5%

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regression found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 1 1 1 0 2
mean2 2.1% 2.3% -1.0% N/A 0.5%
max 2.1% 2.3% -1.0% N/A 2.1%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes ↩ ↩2

  2. the arithmetic mean of the percent change ↩ ↩2

@rustbot rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels May 20, 2022
@Kobzol
Copy link
Contributor Author

Kobzol commented May 21, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Jun 10, 2022

⌛ Trying commit 93ff904 with merge d3b259f9622b4fb396bba698cc1df6dfdf5d3026...

@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 3, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Jul 3, 2022

⌛ Trying commit 44ad613 with merge 731282f819829b43dccdc7437b204705b7aec048...

@bors
Copy link
Collaborator

bors commented Jul 3, 2022

☀️ Try build successful - checks-actions
Build commit: 731282f819829b43dccdc7437b204705b7aec048 (731282f819829b43dccdc7437b204705b7aec048)

@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 7, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Jul 7, 2022

⌛ Trying commit 44ad613 with merge bcd41abefbf14dc1eec130e985171a28a4ccbcd2...

@bors
Copy link
Collaborator

bors commented Jul 7, 2022

☀️ Try build successful - checks-actions
Build commit: bcd41abefbf14dc1eec130e985171a28a4ccbcd2 (bcd41abefbf14dc1eec130e985171a28a4ccbcd2)

@rust-timer
Copy link
Collaborator

Queued bcd41abefbf14dc1eec130e985171a28a4ccbcd2 with parent e78e747, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bcd41abefbf14dc1eec130e985171a28a4ccbcd2): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 0.8% 1.4% 34
Regressions 😿
(secondary)		 1.2% 1.4% 10
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 0.8% 1.4% 34

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 0.4% 0.4% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 0.4% 0.4% 1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.4% 2.5% 2
Improvements 🎉
(primary)		 -1.6% -1.8% 5
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -1.6% -1.8% 5

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 7, 2022
@Mark-Simulacrum Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2022
@Mark-Simulacrum
Copy link
Member

Seems like the results here are worse than not doing this; I'm going to go ahead and close but feel free to reopen if needed.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 25, 2022

Some of the previous runs had nice cycle wins, but they were gone in the last round, and this type of PGO made dist builds quite slower, so it was not worth it.

@Kobzol Kobzol mentioned this pull request May 20, 2023
Closed
@Kobzol Kobzol deleted the pgo-cs branch May 20, 2023 21:45
@Kobzol Kobzol mentioned this pull request Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kobzol @rust-timer @bors @rust-log-analyzer @Mark-Simulacrum @rustbot