Skip to content

[DO NOT MERGE] Perf experiment with different cargo defaults#94851

Closed
lqd wants to merge 2 commits into
rust-lang:masterfrom
lqd:cargo-build-defaults
Closed

[DO NOT MERGE] Perf experiment with different cargo defaults#94851
lqd wants to merge 2 commits into
rust-lang:masterfrom
lqd:cargo-build-defaults

Conversation

@lqd

@lqd lqd commented Mar 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

I'm not sure this is even going to build on CI, or whether the results I see locally are going to show up on perf.rlo: the collector mostly benchmarks leaf crates and this changes how the dependencies are built, not the leaf crate.

Maybe it'll have an effect on bootstrap.

In any case it'll at least show whether this is the correct way to benchmark with a different cargo.

r? @ghost

@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@lqd
lqd force-pushed the cargo-build-defaults branch from 39cf2b9 to 0a122f4 Compare March 11, 2022 15:38
@lqd

lqd commented Mar 11, 2022

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

rust-timer commented Mar 11, 2022

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 11, 2022
@bors

bors commented Mar 11, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 0a122f4 with merge 69f654c9aa82e79f56e16f66b3c8a17019ac7289...

@Dylan-DPC
Dylan-DPC marked this pull request as draft March 11, 2022 16:09
@bors

bors commented Mar 11, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 69f654c9aa82e79f56e16f66b3c8a17019ac7289 (69f654c9aa82e79f56e16f66b3c8a17019ac7289)

@rust-timer

rust-timer commented Mar 11, 2022

Copy link
Copy Markdown
Collaborator

Queued 69f654c9aa82e79f56e16f66b3c8a17019ac7289 with parent f58d51b, future comparison URL.

@rust-timer

rust-timer commented Mar 11, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (69f654c9aa82e79f56e16f66b3c8a17019ac7289): comparison url.

Summary: This benchmark run shows 31 relevant improvements 🎉 to instruction counts.

  • Arithmetic mean of relevant regressions: 0.4%
  • Arithmetic mean of relevant improvements: -1.5%
  • Arithmetic mean of all relevant changes: -1.4%
  • Largest improvement in instruction counts: -6.6% on incr-unchanged builds of cargo check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 11, 2022
@lqd lqd closed this Mar 11, 2022
@lqd
lqd deleted the cargo-build-defaults branch March 11, 2022 19:50
@lqd lqd mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lqd @rust-log-analyzer @rust-timer @bors @rustbot