CI: make docker cache download and docker load time out after 10 minutes#90122
Merged
Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
On second thought it seems much more likely that docker load hangs. |
This comment has been minimized.
This comment has been minimized.
hkratz
force-pushed
the
ci_curl_max_time
branch
from
93f9b91 to
3e8b7de
Compare
hkratz
force-pushed
the
ci_curl_max_time
branch
from
3e8b7de to
838e673
Compare
Member
|
@bors r+ |
Collaborator
|
📌 Commit 838e673 has been approved by |
bors
added
S-waiting-on-bors
Contributor
Author
|
@Mark-Simulacrum I now strongly suspect that it is We could try |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 21, 2021
…k-Simulacrum CI: make docker cache download attempt time out after 10 minutes Might help to prevent timeouts we have been seeing: * https://github.com/rust-lang-ci/rust/runs/3946294286?check_suite_focus=true#step:25:23 * https://github.com/rust-lang-ci/rust/runs/3956799200?check_suite_focus=true#step:25:22
Contributor
Author
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 21, 2021
…k-Simulacrum CI: make docker cache download attempt time out after 10 minutes Might help to prevent timeouts we have been seeing: * https://github.com/rust-lang-ci/rust/runs/3946294286?check_suite_focus=true#step:25:23 * https://github.com/rust-lang-ci/rust/runs/3956799200?check_suite_focus=true#step:25:22 * https://github.com/rust-lang-ci/rust/runs/3962928502?check_suite_focus=true#step:25:23
hkratz
changed the title
docker load time out after 10 minutes
Contributor
Author
|
Adding timeout for |
hkratz
force-pushed
the
ci_curl_max_time
branch
from
83fb7ec to
f6dec14
Compare
hkratz
force-pushed
the
ci_curl_max_time
branch
from
f6dec14 to
3e6a695
Compare
Contributor
Author
|
@rustbot label -S-waiting-on-bors +S-waiting-on-review |
rustbot
added
S-waiting-on-review
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 3e6a695 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 23, 2021
…askrgr Rollup of 11 pull requests Successful merges: - rust-lang#83233 (Implement split_array and split_array_mut) - rust-lang#88300 (Stabilise unix_process_wait_more, extra ExitStatusExt methods) - rust-lang#89416 (nice_region_error: Include lifetime placeholders in error output) - rust-lang#89468 (Report fatal lexer errors in `--cfg` command line arguments) - rust-lang#89730 (add feature flag for `type_changing_struct_update`) - rust-lang#89920 (Implement -Z location-detail flag) - rust-lang#90070 (Add edition configuration to compiletest) - rust-lang#90087 (Sync rustfmt subtree) - rust-lang#90117 (Make RSplit<T, P>: Clone not require T: Clone) - rust-lang#90122 (CI: make docker cache download and `docker load` time out after 10 minutes) - rust-lang#90166 (Add comment documenting why we can't use a simpler solution) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might help to prevent timeouts we have been seeing:
If the download or loading the images into docker times out the CI will still continue and rebuild the docker image from scratch.