Use standard formatting for "rust-call" ABI message #80809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
A-diagnostics
Contributor
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Collaborator
|
📌 Commit 4e3be7c has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 10, 2021
Use standard formatting for "rust-call" ABI message Nearly all error messages start with a lowercase letter and don't use articles - instead they refer to the plural case.
Member
|
Failed in rollup: https://github.com/rust-lang/rust/runs/1676010238 @bors r- |
bors
added
S-waiting-on-author
Nearly all error messages start with a lowercase letter and don't use articles - instead they refer to the plural case.
camelid
added
S-waiting-on-review
camelid
force-pushed
the
rust-call-abi-msg
branch
from
4e3be7c to
6488aec
Compare
Member
Author
|
Ready for re-approval. |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 6488aec has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 11, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#80809 (Use standard formatting for "rust-call" ABI message) - rust-lang#80872 (Fix typo in source-based-code-coverage.md) - rust-lang#80878 (Add ABI argument to `find_mir_or_eval_fn`) - rust-lang#80881 ( Fix intra-doc links to `Self` and `crate` ) - rust-lang#80887 (log-color: Detect TTY based on stderr, not stdout) - rust-lang#80892 (rustdoc: Remove `*` intra-doc alias for `pointer`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
Member
Author
|
Heh, looks like there was a race between the rollup merge and bors testing 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nearly all error messages start with a lowercase letter and don't use
articles - instead they refer to the plural case.