Skip to content

Add regression issue template #77725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Oct 14, 2020
Merged

Add regression issue template #77725

bors merged 1 commit into from
Oct 14, 2020

Conversation

@camelid
Copy link
Member

@camelid camelid commented Oct 8, 2020

Feel free to suggest improvements!

@camelid camelid added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Oct 8, 2020
@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 8, 2020

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2020
@camelid camelid mentioned this pull request Oct 8, 2020
Merged
jyn514
jyn514 reviewed Oct 8, 2020
View reviewed changes
Mark-Simulacrum
Mark-Simulacrum reviewed Oct 9, 2020
View reviewed changes
@camelid camelid mentioned this pull request Oct 9, 2020
Merged
camelid
camelid commented Oct 9, 2020
View reviewed changes
@camelid camelid marked this pull request as ready for review October 9, 2020 21:22
jyn514
jyn514 reviewed Oct 9, 2020
View reviewed changes
@camelid
Copy link
Member Author

camelid commented Oct 10, 2020

Squashed. Ready for review!

@camelid camelid force-pushed the regression-template branch from d25e260 to ccf6370 Compare October 10, 2020 00:42
@jyn514

This comment has been minimized.

Sign in to view
@camelid

This comment has been minimized.

Sign in to view
@LeSeulArtichaut LeSeulArtichaut added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2020
@LeSeulArtichaut
Copy link
Contributor

LeSeulArtichaut commented Oct 10, 2020

I'm worried that this template sort of intersects with both the Bug and ICE ones. How could we make it easier for a new bug reporter which template to use?

@LeSeulArtichaut LeSeulArtichaut added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 11, 2020
@LeSeulArtichaut
Copy link
Contributor

LeSeulArtichaut commented Oct 11, 2020

#77769 landed

@camelid
Copy link
Member Author

camelid commented Oct 11, 2020

I'm worried that this template sort of intersects with both the Bug and ICE ones. How could we make it easier for a new bug reporter which template to use?

Any ideas? :P

@jyn514
Copy link
Member

jyn514 commented Oct 11, 2020

Maybe change 'Bug' -> 'Existing Bug'? 'existing' is a little ambiguous if you don't know it's talking about releases, though ...

@camelid
Copy link
Member Author

camelid commented Oct 11, 2020

Another issue is that people might not know what a "regression" is :/

LeSeulArtichaut
LeSeulArtichaut reviewed Oct 11, 2020
View reviewed changes
@LeSeulArtichaut
Copy link
Contributor

LeSeulArtichaut commented Oct 11, 2020

Maybe change 'Bug' -> 'Existing Bug'? 'existing' is a little ambiguous if you don't know it's talking about releases, though ...

I personally find it more confusing

@mark-i-m
Copy link
Contributor

mark-i-m commented Oct 11, 2020

How about something like "Breakage on Stable Rust"

@apiraino
Copy link
Contributor

apiraino commented Oct 11, 2020 •
edited
Loading

How about something like "Breakage on Stable Rust"

If I'm not wrong a regression in this repository can be:

  • from stable to stable (i.e. a stable breaks another stable - perhaps the case that you mention)
  • from stable to beta or nightly (i.e. a nightly/beta breaks stable)
  • from beta to nightly (i.e. a nightly breaks a beta)

My suggestion "The issue breaks a previous Rust version"?

edit: which is what LeSeulArtichaut wrote

apiraino
apiraino reviewed Oct 11, 2020
View reviewed changes
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Oct 13, 2020

Please squash the commits; r=me after that. I imagine we'll want to iterate but seems good to get something merged in the meantime.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2020
@camelid camelid force-pushed the regression-template branch from bb0e53a to 91cc3d2 Compare October 13, 2020 18:10
@camelid
Copy link
Member Author

camelid commented Oct 13, 2020

Squashed!

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2020
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Oct 13, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 13, 2020

📌 Commit 91cc3d2 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2020
@JohnTitor JohnTitor mentioned this pull request Oct 13, 2020
Merged
@bors bors merged commit 1bb6eff into rust-lang:master Oct 14, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 14, 2020
@camelid camelid deleted the regression-template branch October 14, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spastorino spastorino spastorino left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

@apiraino apiraino apiraino left review comments

+3 more reviewers

@bugadani bugadani bugadani left review comments

@jyn514 jyn514 jyn514 left review comments

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.