Skip to content

Detect turbofish with multiple type params missing leading :: #76171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Sep 15, 2020
Merged

Detect turbofish with multiple type params missing leading :: #76171

bors merged 1 commit into from
Sep 15, 2020

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Aug 31, 2020

Fix #76072.

@rust-highfive
Copy link
Contributor

rust-highfive commented Aug 31, 2020

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2020
@jyn514 jyn514 added the A-diagnostics Area: Messages for errors, warnings, and lints label Sep 1, 2020
jyn514
jyn514 reviewed Sep 1, 2020
View reviewed changes
@jyn514 jyn514 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 1, 2020
@estebank estebank force-pushed the turbofish-the-revenge branch from 0ebce65 to 8357a95 Compare September 1, 2020 20:45
@jonas-schievink
Copy link
Contributor

jonas-schievink commented Sep 13, 2020

r? @davidtwco

davidtwco
davidtwco requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after fixing this

@estebank estebank force-pushed the turbofish-the-revenge branch from 8357a95 to 62effcb Compare September 14, 2020 19:07
@davidtwco
Copy link
Member

davidtwco commented Sep 15, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 15, 2020

📌 Commit 62effcb has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2020
@bors
Copy link
Collaborator

bors commented Sep 15, 2020

⌛ Testing commit 62effcb with merge 90b1f5a...

@bors
Copy link
Collaborator

bors commented Sep 15, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: davidtwco
Pushing 90b1f5a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 15, 2020
@bors bors merged commit 90b1f5a into rust-lang:master Sep 15, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 15, 2020
@bors bors mentioned this pull request Sep 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco requested changes

+1 more reviewer

@jyn514 jyn514 jyn514 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@davidtwco davidtwco

Labels

A-diagnostics Area: Messages for errors, warnings, and lints merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

Handle missing turbofish with multiple type params in the parser

8 participants

@estebank @rust-highfive @jonas-schievink @davidtwco @bors @jyn514 @nikomatsakis @rustbot