Avoid StringReader when checking code blocks for syntax errors #76068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
added
C-cleanup
Contributor
Author
|
This fails the r? @GuillaumeGomez (but this a WIP due to the test failure) |
Contributor
Contributor
Author
|
Yes: specifying r? @username directly in the PR description leads to ping amplification (as PR description is included in the commit message generated by bors). So I write ghost and then assign the actual reviewer in the second comment. |
Contributor
|
Ah, I got confused for a moment. I forgot this is rustdoc and @GuillaumeGomez is a reviewer, I thought you made a typo on the reviewer. |
matklad
force-pushed
the
checkcodeblock
branch
from
1404c72 to
d1a3e99
Compare
matklad
changed the title
Contributor
Author
|
Fixed the test failure, should be ready to review now! |
matklad
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Aug 30, 2020
Member
|
Looks good to me. Since you ping @petrochenkov, I'll let them take a look first as well. cc @jyn514 |
`parse_stream_from_source_str` is a more stable API to convert a string into a bunch of tokens, and it also catches errors about mismatched parenthesis.
matklad
force-pushed
the
checkcodeblock
branch
from
d1a3e99 to
1baf3ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_stream_from_source_stris a more stable API to convert astring into a bunch of tokens, and it also catches errors about
mismatched parenthesis.
r? @ghost