Skip to content

Conversation

@golddranks
Copy link
Contributor

Implements the APIs described here: rust-lang/rfcs#2806 behind a feature flag rejoin_slice.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2019
@jonas-schievink jonas-schievink added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 4, 2019
@Centril
Copy link
Contributor

Centril commented Nov 5, 2019

r? @rkruppe cc @RalfJung

@golddranks
Copy link
Contributor Author

This cannot be merged as-is as it was deemed to be unsafe. However, it might be useful to have an unsafe version in standard library. It would be good from the perspective of communicating what is UB and what is not, and why, too.

@RalfJung
Copy link
Member

RalfJung commented Nov 5, 2019

(I am going to respond in the RFC, let us centralize the discussion there: rust-lang/rfcs#2806)

@Centril
Copy link
Contributor

Centril commented Nov 5, 2019

Closing the PR for now then.

@Centril Centril closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants