Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rustdoc] Specific crate search #54706

Closed
wants to merge 2 commits into from
Closed

[rustdoc] Specific crate search #54706

wants to merge 2 commits into from

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2018
@GuillaumeGomez
Copy link
Member Author

@QuietMisdreavus: You can see it in action here: http://gtk-rs.org/docs/gtk/struct.Window.html

QuietMisdreavus
QuietMisdreavus reviewed Oct 17, 2018
View reviewed changes
Copy link
Member

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is nice! I think it'd be ideal if it was using the sans-serif font. (And as a bonus, could it also have a little magnifying glass icon? Something like https://www.fileformat.info/info/unicode/char/1f50d/index.htm, i guess. It seems like a little touch that would make it nicer.)

src/librustdoc/html/static/main.js
@@ -1376,8 +1385,13 @@
var ret_in_args = addTab(results['in_args'], query, false);
var ret_returned = addTab(results['returned'], query, false);

var filter = "";
if (filterCrates !== undefined) {
filter = " (in <b>" + filterCrates + "</b> crate)";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording nit:

Suggested change
filter = " (in <b>" + filterCrates + "</b> crate)";
filter = " (in crate <b>" + filterCrates + "</b>)";

@GuillaumeGomez
Copy link
Member Author

It's complicated because it takes already a lot of space and I'm worried that it might be an issue on mobile devices. However I intend to put arrows on the right of the (heavily modified) select box. That might help a bit.

@bors
Copy link
Collaborator

bors commented Oct 18, 2018

☔ The latest upstream changes (presumably #55171) made this pull request unmergeable. Please resolve the merge conflicts.

@TimNN TimNN added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2018
@QuietMisdreavus
Copy link
Member

Re-review note: the wording nit still stands, and there's now a merge conflict. It's okay if we can't include the little icon, but can we still use the sans-serif font? I feel like it would be better to use it there, since it's in more of a "heading" position than a "body text" position, where we use the serif font currently.

image

@QuietMisdreavus QuietMisdreavus mentioned this pull request Nov 2, 2018
Open
@GuillaumeGomez
Copy link
Member Author

Sure, I didn't come back to this PR yet. :)

@TimNN
Copy link
Contributor

TimNN commented Nov 13, 2018

Ping from triage @GuillaumeGomez!

@GuillaumeGomez
Copy link
Member Author

Still the same.

@TimNN
Copy link
Contributor

TimNN commented Nov 27, 2018

Ping from triage! This PR hasn't made any progress in a while, so I'm closing it per our triage guidelines. Thanks for your contributions and please feel free to re-open in the future.

@TimNN TimNN closed this Nov 27, 2018
@TimNN TimNN added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 27, 2018
@GuillaumeGomez
Copy link
Member Author

I added the arrow as you can see here:

screenshot 2018-11-29 at 01 29 11

@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 29, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Dec 4, 2018
@kennytm
Rollup merge of rust-lang#56332 - GuillaumeGomez:specifi-crate-search…
40337a1 
…, r=QuietMisdreavus

[rustdoc] Specific crate search

Reopening of rust-lang#54706.
Fixes rust-lang#54616.

<img width="1440" alt="screenshot 2018-11-29 at 01 29 11" src="https://user-images.githubusercontent.com/3050060/49191372-979adf80-f376-11e8-963e-e4feb927c1da.png">

r? @QuietMisdreavus
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 4, 2018
@GuillaumeGomez
Rollup merge of rust-lang#56332 - GuillaumeGomez:specifi-crate-search…
7eda308 
…, r=QuietMisdreavus

[rustdoc] Specific crate search

Reopening of rust-lang#54706.
Fixes rust-lang#54616.

<img width="1440" alt="screenshot 2018-11-29 at 01 29 11" src="https://user-images.githubusercontent.com/3050060/49191372-979adf80-f376-11e8-963e-e4feb927c1da.png">

r? @QuietMisdreavus
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 5, 2018
@GuillaumeGomez
Rollup merge of rust-lang#56332 - GuillaumeGomez:specifi-crate-search…
7f67a73 
…, r=QuietMisdreavus

[rustdoc] Specific crate search

Reopening of rust-lang#54706.
Fixes rust-lang#54616.

<img width="1440" alt="screenshot 2018-11-29 at 01 29 11" src="https://user-images.githubusercontent.com/3050060/49191372-979adf80-f376-11e8-963e-e4feb927c1da.png">

r? @QuietMisdreavus
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 5, 2018
@pietroalbini
Rollup merge of rust-lang#56332 - GuillaumeGomez:specifi-crate-search…
3f97a7e 
…, r=QuietMisdreavus

[rustdoc] Specific crate search

Reopening of rust-lang#54706.
Fixes rust-lang#54616.

<img width="1440" alt="screenshot 2018-11-29 at 01 29 11" src="https://user-images.githubusercontent.com/3050060/49191372-979adf80-f376-11e8-963e-e4feb927c1da.png">

r? @QuietMisdreavus
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 6, 2018
@pietroalbini
Rollup merge of rust-lang#56332 - GuillaumeGomez:specifi-crate-search…
a88feab 
…, r=QuietMisdreavus

[rustdoc] Specific crate search

Reopening of rust-lang#54706.
Fixes rust-lang#54616.

<img width="1440" alt="screenshot 2018-11-29 at 01 29 11" src="https://user-images.githubusercontent.com/3050060/49191372-979adf80-f376-11e8-963e-e4feb927c1da.png">

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuietMisdreavus QuietMisdreavus QuietMisdreavus left review comments

Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @bors @QuietMisdreavus @TimNN @rust-highfive