Convert all uses of vec::slice to vec::view Issue #3869#4969
Closed
nickdesaulniers wants to merge 2 commits intorust-lang:incomingfrom
nickdesaulniers:issue3869
Closed
Convert all uses of vec::slice to vec::view Issue #3869#4969nickdesaulniers wants to merge 2 commits intorust-lang:incomingfrom nickdesaulniers:issue3869
nickdesaulniers wants to merge 2 commits intorust-lang:incomingfrom
nickdesaulniers:issue3869
Conversation
Rename const_view to const_slice Renamed mut_view to mut_slice
`as_mut_buf()` and so we must invoke `slice()` outside of that call.
bors
added a commit
that referenced
this pull request
Feb 15, 2013
Issue #3869 review? @nikomatsakis Convert all uses of vec::slice to vec::view Issue #3869 Rename const_view to const_slice Renamed mut_view to mut_slice Fix windows build error. `buf` is borrowed by the call to `as_mut_buf()` and so we must invoke `slice()` outside of that call.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
…consts-fp, r=phansch Prevent `replace_consts` lint within match patterns Currently `replace_consts` lint applies within match patterns but the suggestion is incorrect as function calls are disallowed in them. To fix this we prevent the lint from firing within patterns. Fixes rust-lang#4969 changelog: Fix false positive in `replace_consts` lint
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Apr 20, 2026
Automatic Rustup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3869
review? @nikomatsakis
Convert all uses of vec::slice to vec::view Issue #3869
Rename const_view to const_slice
Renamed mut_view to mut_slice
Fix windows build error.
bufis borrowed by the call toas_mut_buf()and so we must invokeslice()outside of thatcall.