Skip to content

Conversation

QuietMisdreavus and others added 9 commits November 4, 2017 14:54
…ol, r=frewsxcv

rustdoc book: talk about #![doc(test(no_crate_inject))] and #![doc(test(attr(...)))]

While investigating rust-lang#45750 i noticed that `#![doc(test(attr(...)))]` wasn't documented at all. Since this is useful for making your examples follow the same coding guidelines as your code, i wanted to add it to the Rustdoc Book. I also added `#![doc(test(no_crate_inject))]` since it's used in the same place and might be useful for macro-heavy crates. I added mentions for these to "The `doc` attribute" as well as "Documentation tests" since it's useful information in both places.

Technically the step reordering in the second commit is gated on rust-lang#45764, since before that lands attributes from the doctest come before the ones from `#![doc(test(attr(...)))]`.
…QuietMisdreavus

Fix primitive types not showing up

Fixes rust-lang#46017.

r? @QuietMisdreavus
@GuillaumeGomez
Copy link
Member Author

@bors: r+ p=1

@bors
Copy link
Collaborator

bors commented Nov 18, 2017

📌 Commit 5f1c37a has been approved by GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Nov 18, 2017

⌛ Testing commit 5f1c37a with merge 18250b0...

bors added a commit that referenced this pull request Nov 18, 2017
Rollup of 4 pull requests

- Successful merges: #45767, #46044, #46066, #46071
- Failed merges:
@bors
Copy link
Collaborator

bors commented Nov 18, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 18250b0 to master...

@bors bors merged commit 5f1c37a into rust-lang:master Nov 18, 2017
@GuillaumeGomez GuillaumeGomez deleted the rollup branch November 18, 2017 22:53
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollup A PR which is a rollup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants