Skip to content

fix some python3 incompatibilities #46044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Nov 18, 2017
Merged

fix some python3 incompatibilities #46044

bors merged 1 commit into from
Nov 18, 2017
+25 −24

Conversation

@collinanderson
Copy link
Contributor

@collinanderson collinanderson commented Nov 16, 2017

No description provided.

kennytm
kennytm approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some nits.

src/libstd_unicode/unicode.py Outdated
Copy link
Member

@kennytm kennytm Nov 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe refactor this to?

if any(lo <= char <= hi for lo, hi in comp_exclusions):
    continue

src/libstd_unicode/unicode.py Outdated
Copy link
Member

@kennytm kennytm Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we ever get non-integer from the source code? All the int() calls could be dropped in not.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2017
@collinanderson
Copy link
Contributor Author

collinanderson commented Nov 16, 2017

Hah. Good points. Fixed both.

@kennytm
Copy link
Member

kennytm commented Nov 16, 2017

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 16, 2017

📌 Commit 261d4d8 has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 18, 2017
@GuillaumeGomez
Rollup merge of rust-lang#46044 - collinanderson:py3, r=kennytm
c36228f 
fix some python3 incompatibilities
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 18, 2017
Merged
bors added a commit that referenced this pull request Nov 18, 2017
@bors
Auto merge of #46073 - GuillaumeGomez:rollup, r=GuillaumeGomez
18250b0 
Rollup of 4 pull requests

- Successful merges: #45767, #46044, #46066, #46071
- Failed merges:
@bors bors merged commit 261d4d8 into rust-lang:master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm approved these changes

Assignees

No one assigned

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@collinanderson @kennytm @bors