deriv(Hash) for single-variant enum should not hash discriminant #42709
+20
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
added
the
S-waiting-on-review
Contributor
|
r? @jseyfried |
Member
|
@jseyfried This is waiting for a review from you, and possibly should get sign off from @rust-lang/libs as well - I don't think if this change is something we want to commit to. Seems fine to me, though. |
Contributor
|
Reviewed, r=me if @rust-lang/libs is OK with the new behavior (I don't have a strong opinion either way). |
Member
|
@bors: r=jseyfried Yeah libs-wise this is fine |
Collaborator
|
📌 Commit f11e40a has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Jun 28, 2017
deriv(Hash) for single-variant enum should not hash discriminant Fixes #39137
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Contributor
Member
|
Reopened. |
Contributor
Author
|
@kryptan yes, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39137