Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding links to option::Option #42163

Merged
merged 1 commit into from
May 23, 2017
Merged

Adding links to option::Option #42163

merged 1 commit into from
May 23, 2017

Conversation

projektir
Copy link
Contributor

@projektir projektir commented May 23, 2017 •
edited
Loading

Just adding some links.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@projektir
Copy link
Contributor Author

r? @frewsxcv

@frewsxcv
Copy link
Member

thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 23, 2017

📌 Commit 6e27bd8 has been approved by frewsxcv

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 23, 2017
@frewsxcv
Rollup merge of rust-lang#42163 - projektir:option_links, r=frewsxcv
aa7762f 
Adding links to option::Option

Just adding some links.
@frewsxcv frewsxcv mentioned this pull request May 23, 2017
Merged
bors added a commit that referenced this pull request May 23, 2017
@bors
Auto merge of #42165 - frewsxcv:rollup, r=frewsxcv
852b7cb 
Rollup of 8 pull requests

- Successful merges: #42016, #42122, #42144, #42145, #42151, #42152, #42160, #42163
- Failed merges:
@bors bors merged commit 6e27bd8 into rust-lang:master May 23, 2017
@projektir projektir deleted the option_links branch May 23, 2017 14:04
@Arnavion
Copy link

Arnavion commented Sep 4, 2017 •
edited
Loading

This added hyperlinks to Default::default for Option::map_or and Option::map_or_else, but default for those functions refers to the parameter and is unrelated to Default::default

Edit: Also, Option::unwrap_or_default would have benefitted from the hyperlink but didn't get one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@projektir @rust-highfive @frewsxcv @bors @Arnavion @alexcrichton