Fix example in the docs #4180

andrew-d · 2012-12-14T01:11:02Z

Relevant to #4140

For example, this fails to compile:

trait Printable {
  fn to_str() -> ~str;
}

impl ~str: Printable {
  fn to_str() -> ~str { copy self }
}

fn main() {
    let s = ~"foobar";
    let v = s.to_str();
    assert v == s;
}

But this passes:

trait Printable {
  fn make_string() -> ~str;
}

impl ~str: Printable {
  fn make_string() -> ~str { copy self }
}

fn main() {
    let s = ~"foobar";
    let v = s.make_string();
    assert v == s;
}

Introduces a temporary 'path2' attribute that will replace 'path' after a snapshot

Fix deriving for single-variant enums

Conflicts: src/libstd/future.rs

The FIXME is an underlying issue (a core::at_str library) that this doesn't address.

When a type error has already occurred, don't call ty::subst, which may ICE due to the mismatch in the number of type params involved. I'm deeming this too small to review. Closes #3680

This disallows using pointers to sneak around priv qualifiers. Deeming this too small for review as well. Closes #3763

As per #3637.

Reverse the order of the results of pipes::stream

r=brson Closes #3788

Remove old syntax ext

There's already a "to_str" impl for string, so it fails here.

andrew-d · 2012-12-14T01:11:40Z

Whoops, wrong branch. Closing and re-opening.

* Preserve comments in empty statements Closes rust-lang#4018 * fixup! Preserve comments in empty statements

Automatic Rustup

brson and others added 26 commits December 11, 2012 15:00

Relate the module hierarchy to directory paths in the parser

6e38e33

Introduces a temporary 'path2' attribute that will replace 'path' after a snapshot

Fix deriving for single-variant enums

7d556e1

Merge pull request #4164 from brson/deriving

bfb09ee

Fix deriving for single-variant enums

libstd: teach workcache to check freshness.

3ee1adb

libstd: refactor future, remove with(), remove ~ indirection.

a55ea48

Conflicts: src/libstd/future.rs

libstd: Implement read_managed_str for the JSON deserialiser.

76dc781

The FIXME is an underlying issue (a core::at_str library) that this doesn't address.

fix long line, r=tidypolice.

35209cb

Avoid extra error for type mismatches in patterns

6439f2d

When a type error has already occurred, don't call ty::subst, which may ICE due to the mismatch in the number of type params involved. I'm deeming this too small to review. Closes #3680

Remove old deriving

a7159be

Auto-deref when checking field and method privacy

d42bdf1

This disallows using pointers to sneak around priv qualifiers. Deeming this too small for review as well. Closes #3763

re-fix typo

b0a01f2

Reverse the order of the results of pipes::stream

38bd694

As per #3637.

Merge pull request #4167 from catamorphism/issue-3637

4ec658e

Reverse the order of the results of pipes::stream

Fix tasks tutorial tests

213773c

Add Huon Wilson to AUTHORS.txt

80d6bc8

syntax: remove all remaining uses of #ast, and #ast / qquote itself.

9cced55

syntax: remove most code handling old-style syntax extensions.

e24ae85

Document pub use foo::* in the reference manual

0138d87

r=brson Closes #3788

syntax: remove remaining #syntaxext machinery. Close #3516.

9a4c669

Merge pull request #4172 from graydon/remove-old-syntax-ext

0494b07

Remove old syntax ext

Fix vtable calculations when translating static methods. Closes #4165

6047dd3

Fix the test for transmute

948754b

core: Remove some uses of 'move'

0d59e86

syntax: normalize paths when parsing, close #4173.

3c8dca4

librustc: Make use statements crate-relative by default. r=brson

4c2e4c3

Rename "to_str" to "make_string" in the docs

08b1c84

There's already a "to_str" impl for string, so it fails here.

andrew-d closed this Dec 14, 2012

bors pushed a commit to rust-lang-ci/rust that referenced this pull request May 15, 2021

Preserve comments in empty statements (rust-lang#4180)

6a78247

* Preserve comments in empty statements Closes rust-lang#4018 * fixup! Preserve comments in empty statements

RalfJung pushed a commit to RalfJung/rust that referenced this pull request Feb 24, 2025

Merge pull request rust-lang#4180 from rust-lang/rustup-2025-02-06

8f11cc0

Automatic Rustup

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix example in the docs #4180

Fix example in the docs #4180

andrew-d commented Dec 14, 2012

andrew-d commented Dec 14, 2012

Fix example in the docs #4180

Fix example in the docs #4180

Conversation

andrew-d commented Dec 14, 2012

andrew-d commented Dec 14, 2012