Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: generic FromIterator and Extend Cow for String #41454

Closed
wants to merge 3 commits into from
Closed

WIP: generic FromIterator and Extend Cow for String #41454

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6563f4a
FromIterator and Extend Cow for String
Eh2406 Apr 21, 2017
343bcdf
FromIterator and Extend Borrow<str> for String
Eh2406 Apr 22, 2017
c215565
remove the conflicting implementations
Eh2406 Apr 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove the conflicting implementations
  • Loading branch information
@Eh2406
Eh2406 committed Apr 22, 2017
commit c215565557c88dc0aa62ea0982ebb9eefebaff1e
30 changes: 0 additions & 30 deletions src/libcollections/string.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,24 +1510,6 @@ impl Clone for String {
}
}

#[stable(feature = "rust1", since = "1.0.0")]
impl FromIterator<char> for String {
fn from_iter<I: IntoIterator<Item = char>>(iter: I) -> String {
let mut buf = String::new();
buf.extend(iter);
buf
}
}

#[stable(feature = "string_from_iter_by_ref", since = "1.17.0")]
impl<'a> FromIterator<&'a char> for String {
fn from_iter<I: IntoIterator<Item = &'a char>>(iter: I) -> String {
let mut buf = String::new();
buf.extend(iter);
buf
}
}

#[stable(feature = "herd_cows", since = "1.9.0")]
impl<T: Borrow<str>> FromIterator<T> for String {
fn from_iter<I: IntoIterator<Item = T>>(iter: I) -> String {
Expand All @@ -1537,18 +1519,6 @@ impl<T: Borrow<str>> FromIterator<T> for String {
}
}

#[stable(feature = "rust1", since = "1.0.0")]
impl Extend<char> for String {
fn extend<I: IntoIterator<Item = char>>(&mut self, iter: I) {
let iterator = iter.into_iter();
let (lower_bound, _) = iterator.size_hint();
self.reserve(lower_bound);
for ch in iterator {
self.push(ch)
}
}
}

#[stable(feature = "herd_cows", since = "1.9.0")]
impl<T: Borrow<str>> Extend<T> for String {
fn extend<I: IntoIterator<Item = T>>(&mut self, iter: I) {
Expand Down