Add example to std::process::abort#41090
Conversation
This is a second (2/3?) step in order to complete this issue: rust-lang#29370 I submitted this PR with the help of @steveklabnik again. Thanks to him! More info here: rust-lang#29370 (comment)
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
steveklabnik
left a comment
steveklabnik
left a comment
There was a problem hiding this comment.
This is fantastic! One tiny, tiny thing though, then this is good to go
src/libstd/process.rs
Outdated
| /// // the destructor implemented for HasDrop will never get run | ||
| /// } | ||
| /// ``` | ||
| /// |
There was a problem hiding this comment.
could you remove this line, please?
src/libstd/process.rs
Outdated
| /// } | ||
| /// ``` | ||
| /// | ||
| /// The abort function terminates the process, so the destructor will not get |
There was a problem hiding this comment.
oh and could this link to abort please?
There was a problem hiding this comment.
There's also whitespace at the end of this line the tidy checker doesn't like.
There was a problem hiding this comment.
Ok for both comments! Thanks!
|
@steveklabnik Ok, everything seems fine now. Thank you again! |
|
@bors: r+ rollup 💯 ❤️ ✨ thank you!!! |
|
📌 Commit 16c77d7 has been approved by |
Add example to std::process::abort This is a second step in order to complete this issue: rust-lang#29370 I submitted this PR with the help of @steveklabnik again. Thanks to him! More info here: rust-lang#29370 (comment)
Add example to std::process::abort This is a second step in order to complete this issue: rust-lang#29370 I submitted this PR with the help of @steveklabnik again. Thanks to him! More info here: rust-lang#29370 (comment)
6 participants
This is a second step in order to complete this issue: #29370
I submitted this PR with the help of @steveklabnik again. Thanks to him! More info here: #29370 (comment)