add a -Z flag to guarantee that MIR is generated for all functions #38217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could this be |
oli-obk
force-pushed
the
mir-for-all-and-all-for-mir
branch
from
c21f62a to
87a9ae2
Compare
Contributor
Author
|
done |
eddyb
changed the title
Member
|
@bors r+ |
Collaborator
|
📌 Commit 87a9ae2 has been approved by |
Member
|
@bors r- |
… decision site before it was assumed that anything that had a MIR was fair game for local instatiation
Contributor
Author
|
This now produces a working compiler (stage2 is building right now) without the flag enabled. It also allows me to compile miri and all its dependencies with the flag enabled (not that there's any point, but I didn't want to wait for an entire compiler to build with the flag enabled). So this is basically working now. I know it has no tests yet. I promise I will write them on monday. Would it be possible to r+ this PR without the tests? |
Contributor
|
I successfully built stage2 with the newest code in this PR and the flag hardcoded to true. |
Member
Collaborator
|
📌 Commit d74d153 has been approved by |
Collaborator
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb
cc @solson