Skip to content

Make private_in_public compatibility lint warn-by-default again #36270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Sep 14, 2016
Merged

Make private_in_public compatibility lint warn-by-default again #36270

bors merged 1 commit into from
Sep 14, 2016

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Sep 4, 2016

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Sep 13, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 13, 2016

📌 Commit 3be6d1f has been approved by nikomatsakis

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Sep 13, 2016

Do we need to backport this to beta?

@nikomatsakis nikomatsakis added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Sep 13, 2016
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Sep 13, 2016

(I'm going to assume we do, cc @brson)

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Sep 13, 2016

Btw, I sent PRs to all affected crates, most of them are merged/published.

@bors
Copy link
Collaborator

bors commented Sep 14, 2016

⌛ Testing commit 3be6d1f with merge f793355...

@bors
Copy link
Collaborator

bors commented Sep 14, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

alexcrichton commented Sep 14, 2016

@bors: retry

On Tue, Sep 13, 2016 at 6:47 PM, bors [email protected] wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/2483

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36270 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95I6zYUd7fuLw_TYlXxHryz4gV9KUks5qp1IkgaJpZM4J0o5Q
.

@bors
Copy link
Collaborator

bors commented Sep 14, 2016

⌛ Testing commit 3be6d1f with merge 5bdf79b...

bors added a commit that referenced this pull request Sep 14, 2016
@bors
Auto merge of #36270 - petrochenkov:pipwarnagain, r=nikomatsakis
5bdf79b 
Make `private_in_public` compatibility lint warn-by-default again

More details: https://internals.rust-lang.org/t/regression-report-stable-2016-08-16-vs-beta-2016-08-26/3930/10

r? @nikomatsakis
@bors
Copy link
Collaborator

bors commented Sep 14, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nikomatsakis
Pushing 5bdf79b to master...

@bors bors merged commit 3be6d1f into rust-lang:master Sep 14, 2016
@brson brson mentioned this pull request Sep 16, 2016
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 19, 2016
@petrochenkov petrochenkov deleted the pipwarnagain branch September 21, 2016 19:59
@petrochenkov petrochenkov mentioned this pull request Oct 1, 2016
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakis nikomatsakis

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov @nikomatsakis @bors @alexcrichton @brson