Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use &mut for CombineFields in inference relations #35040

Merged
merged 5 commits into from
Jul 28, 2016
Merged

Use &mut for CombineFields in inference relations #35040

merged 5 commits into from
Jul 28, 2016

Conversation

soltanmm
Copy link

Because dropping obligations on the floor makes a mess.

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

Very cool. Fast work.

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 26, 2016

📌 Commit 4bcf013 has been approved by nikomatsakis

@bors
Copy link
Collaborator

bors commented Jul 26, 2016

⌛ Testing commit 4bcf013 with merge a74d7de...

@bors
Copy link
Collaborator

bors commented Jul 26, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Jul 26, 2016 at 6:00 AM, bors [email protected] wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/1980

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#35040 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95AggC2JiWTgwbofI4CdpgudY6FJ1ks5qZgTjgaJpZM4JUr0T
.

@Manishearth Manishearth mentioned this pull request Jul 28, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 28, 2016
@Manishearth
Rollup merge of rust-lang#35040 - soltanmm:couple-is-a-pun, r=nikomat…
bc283bb 
…sakis

Use &mut for `CombineFields` in inference relations

Because dropping obligations on the floor makes a mess.

r? @nikomatsakis
bors added a commit that referenced this pull request Jul 28, 2016
@bors
Auto merge of #35086 - Manishearth:rollup, r=Manishearth
748ecb1 
Rollup of 7 pull requests

- Successful merges: #34951, #34963, #34969, #35013, #35037, #35040, #35058
- Failed merges:
@bors bors merged commit 4bcf013 into rust-lang:master Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soltanmm @nikomatsakis @bors @alexcrichton @soltanmm-google