Skip to content

Conversation

@eddyb
Copy link
Member

@eddyb eddyb commented Mar 23, 2016

Fixes #32384 by not using MIR on MSVC for the functions in the path of the backtrace.
This is the known blocker for the MSVC MIR builder, hopefully the only one overall.
r? @alexcrichton Confirmed to work on a nightly, by @retep998.

@alexcrichton
Copy link
Member

@bors: r+

On Tuesday, March 22, 2016, Rust highfive robot [email protected]
wrote:

Assigned #32437 #32437 to
@alexcrichton https://github.com/alexcrichton.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#32437 (comment)

@bors
Copy link
Collaborator

bors commented Mar 23, 2016

📌 Commit 424fa43 has been approved by alexcrichton

@eddyb
Copy link
Member Author

eddyb commented Mar 23, 2016

@bors rollup

eddyb added a commit to eddyb/rust that referenced this pull request Mar 23, 2016
Annotate run-pass/backtrace with #[rustc_no_mir] on MSVC.

Fixes rust-lang#32384 by not using MIR on MSVC for the functions in the path of the backtrace.
This is the known blocker for the MSVC MIR builder, hopefully the only one overall.
r? @alexcrichton Confirmed to work on a nightly, by @retep998.
bors added a commit that referenced this pull request Mar 23, 2016
Rollup of 11 pull requests

- Successful merges: #32404, #32420, #32423, #32425, #32429, #32430, #32431, #32434, #32437, #32441, #32443
- Failed merges:
@bors bors merged commit 424fa43 into rust-lang:master Mar 23, 2016
@eddyb eddyb deleted the orbital-msvc branch March 23, 2016 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants