rustbuild: Fix LLVM compile on MinGW #32266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 9452bf9 has been approved by |
Member
Author
The LLVM change [1] in rust-lang#32239 unfortunately broke the LLVM build on MinGW, so this LLVM submodule update brings in one more fix [2] which should hopefully remedy that. Once this lands we should be able to immediately start gating on this to prevent it from happening again. [1]: rust-lang/llvm@be89e4b5 [2]: rust-lang/llvm@3dcd2c84
alexcrichton
force-pushed
the
fix-mingw-rustbuild-again
branch
from
9452bf9 to
41e184c
Compare
Member
Author
Collaborator
bors
added a commit
that referenced
this pull request
Mar 16, 2016
rustbuild: Fix LLVM compile on MinGW The LLVM change [1] in #32239 unfortunately broke the LLVM build on MinGW, so this LLVM submodule update brings in one more fix [2] which should hopefully remedy that. Once this lands we should be able to immediately start gating on this to prevent it from happening again. [1]: rust-lang/llvm@be89e4b5 [2]: rust-lang/llvm@3dcd2c84
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LLVM change 1 in #32239 unfortunately broke the LLVM build on MinGW, so
this LLVM submodule update brings in one more fix 2 which should hopefully
remedy that.
Once this lands we should be able to immediately start gating on this to prevent
it from happening again.