Implement RFC 1461#31945
Conversation
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
Works on Windows now. I ended up backing out the addition of We should probably split the keepalive functionality into two methods to mirror how things work, and possibly move the interval accessor to a unix-only extension trait, but that should be worked out in the net2 crate. |
There was a problem hiding this comment.
In this case two IPv4 and IPv6 applications can bind the same port at the same time
This sounds somewhat misleading. Wouldn't that be one of each?
Also back out keepalive support for TCP since the API is perhaps not actually what we want. You can't read the interval on Windows, and we should probably separate the functionality of turning keepalive on and overriding the interval.
|
|
||
| t!(stream.set_nonblocking(true)); | ||
| t!(stream.set_nonblocking(false)); | ||
| } |
There was a problem hiding this comment.
Could you add a read here to make sure it doesn't block?
|
Thanks @sfackler! 1.8 has been branched, so feel free to r=me with a few nits addressed |
|
@bors r=alexcrichton |
|
📌 Commit 631fa2b has been approved by |
|
⌛ Testing commit 631fa2b with merge f1eccfb... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors r=alexcrichton |
|
📌 Commit c8eb1e2 has been approved by |
|
⌛ Testing commit c8eb1e2 with merge 01cdce9... |
|
@bors r=alexcrichton |
|
📌 Commit ee62aab has been approved by |
|
⌛ Testing commit ee62aab with merge f7f9d8a... |
|
💔 Test failed - auto-linux-cross-opt |
|
@bors r=alexcrichton |
|
📌 Commit e4aa513 has been approved by |
I have these tagged as stable in 1.9, so this shouldn't merge until the 1.8 beta's cut.
sfackler
added
the
relnotes
6 participants
I have these tagged as stable in 1.9, so this shouldn't merge until the 1.8 beta's cut.