Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start documenting BTreeMap's node interface #31441

Merged
merged 2 commits into from
Apr 17, 2016
Merged

Start documenting BTreeMap's node interface #31441

merged 2 commits into from
Apr 17, 2016

Conversation

gereeter
Copy link
Contributor

@gereeter gereeter commented Feb 6, 2016

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

r? @gankro

@rust-highfive rust-highfive assigned Gankra and unassigned alexcrichton Feb 6, 2016
@Gankra
Copy link
Contributor

Gankra commented Feb 6, 2016

💖

Gankra
Gankra reviewed Feb 6, 2016
View reviewed changes
src/libcollections/btree/node.rs
// - Trees must have uniform depth/height. This means that every path down to a leaf from a
// given node has exactly the same length.
// - A node of length `n` has `n` keys, `n` values, and (in an internal node) `n + 1` edges.
// This implies that even an empty node has at least one edge.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty internal node

@Gankra
Copy link
Contributor

Gankra commented Feb 6, 2016

Done review

@gereeter
Copy link
Contributor Author

Sorry for being slow about this - I've been busy with schoolwork. I think I dealt with all your comments.

@bluss
Copy link
Member

bluss commented Apr 15, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 15, 2016

📌 Commit fa8556e has been approved by bluss

@bluss
Copy link
Member

bluss commented Apr 15, 2016

@bors rollup

@bors
Copy link
Collaborator

bors commented Apr 16, 2016

⌛ Testing commit fa8556e with merge c67dc08...

@bors
Copy link
Collaborator

bors commented Apr 16, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Sat, Apr 16, 2016 at 4:38 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/735

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#31441 (comment)

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2016
@Manishearth
Rollup merge of rust-lang#31441 - gereeter:btree-docs, r=bluss
e59af6c 
Start documenting BTreeMap's node interface

cc @gankro @apasel422
@Manishearth Manishearth mentioned this pull request Apr 17, 2016
Merged
bors added a commit that referenced this pull request Apr 17, 2016
@bors
Auto merge of #33049 - Manishearth:rollup, r=Manishearth
a626400 
Rollup of 10 pull requests

- Successful merges: #31441, #32956, #33003, #33022, #33023, #33032, #33039, #33044, #33045, #33046
- Failed merges:
@bors bors merged commit fa8556e into rust-lang:master Apr 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Gankra Gankra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gereeter @rust-highfive @alexcrichton @Gankra @bluss @bors