Skip to content

Better error when rustc fails to write output.#2910

Merged
catamorphism merged 1 commit into
rust-lang:incomingfrom
gwillen:bug-2360
Jul 20, 2012
Merged

Better error when rustc fails to write output.#2910
catamorphism merged 1 commit into
rust-lang:incomingfrom
gwillen:bug-2360

Conversation

@gwillen

@gwillen gwillen commented Jul 13, 2012

Copy link
Copy Markdown
Contributor

For bug #2360. When we construct our raw_fd_ostream for the output file in our LLVM wrapper, stop ignoring the error output.

@catamorphism

Copy link
Copy Markdown
Contributor

Looks good, thanks!

catamorphism added a commit that referenced this pull request Jul 20, 2012
Better error when rustc fails to write output.
@catamorphism catamorphism merged commit ce46e11 into rust-lang:incoming Jul 20, 2012
@graydon graydon mentioned this pull request Jul 25, 2012
celinval added a commit to celinval/rust-dev that referenced this pull request Jun 4, 2024
…ng#2910)

The main changes needed to make this migration besides a few method call
tweaks were:
1. Adapt `FunctionCtx` to cache information about the StableMIR version
of instance and its body.
- I also cleaned up how we were handling basic blocks which were
unnecessary.
2. Created a new ty_stable module that provide stable versions to
retrieve type information from StableMIR.
- I decided to keep these separate so it is cleaner for now. I foresee
that the type module will still rely on internal APIs for the next
little while, so separating them here made sense to me.
3. Since `Place` when retrieved from StableMIR body already comes
monomorphized, I modified the existing `codegen_place` to preemptively
monomorphize Place before converting it to a Stable version and invoking
`codegen_place_stable`.

### Call-outs

Leaving this as a draft for now since this still depends on the
following PRs to be merged into the Rust compiler:
  - rust-lang#118524
  - rust-lang#118516

---------

Co-authored-by: Adrian Palacios <[email protected]>
tshepang pushed a commit to tshepang/rust that referenced this pull request Jul 4, 2026
update autodiff install docs for nix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants