Skip to content

Update hello-world.md#24148

Merged
bors merged 1 commit into
rust-lang:masterfrom
xfq:patch-2
Apr 7, 2015
Merged

Update hello-world.md#24148
bors merged 1 commit into
rust-lang:masterfrom
xfq:patch-2

Conversation

@xfq

@xfq xfq commented Apr 7, 2015

Copy link
Copy Markdown
Contributor

People use programming language implementations like Ruby MRI, CPython, and SpiderMonkey for executing programs.

People use programming language *implementations* like Ruby MRI, CPython, and SpiderMonkey for executing programs.
@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@xfq

xfq commented Apr 7, 2015

Copy link
Copy Markdown
Contributor Author

r? @steveklabnik

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+

@bors

bors commented Apr 7, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 6eea426 has been approved by steveklabnik

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: rollup

@steveklabnik

Copy link
Copy Markdown
Contributor

Thank you! This is one of those things that's easy to get wrong in conversation :(

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 7, 2015
People use programming language *implementations* like Ruby MRI, CPython, and SpiderMonkey for executing programs.
bors added a commit that referenced this pull request Apr 7, 2015
@bors bors merged commit 6eea426 into rust-lang:master Apr 7, 2015
@xfq xfq deleted the patch-2 branch April 7, 2015 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants