Skip to content

Remove unnecessary Arc usage in introduction#23277

Merged
bors merged 1 commit into
rust-lang:masterfrom
aochagavia:intro
Apr 7, 2015
Merged

Remove unnecessary Arc usage in introduction#23277
bors merged 1 commit into
rust-lang:masterfrom
aochagavia:intro

Conversation

@aochagavia

Copy link
Copy Markdown
Contributor

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik

Copy link
Copy Markdown
Contributor

Hmm, the point is to introduce comboing Arc and Mutex together. The examples have gotten a bit out of sync from each other, I think, but I'm not sure this is the right way to address this. Thoughts?

@aochagavia

Copy link
Copy Markdown
Contributor Author

I also think it is nice to introduce Arc. However, I think it is difficult to find a trivial example where it makes sense to use it (probably with detached threads).

@huonw

huonw commented Apr 6, 2015

Copy link
Copy Markdown
Contributor

r? @steveklabnik (transferring reviewership, don't have the bandwidth right now.)

@rust-highfive rust-highfive assigned steveklabnik and unassigned huonw Apr 6, 2015
@steveklabnik

Copy link
Copy Markdown
Contributor

I'm planning on doing more overhauls to this section, but let's just merge this for now, and we'llsee how it ends up.

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Apr 6, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 5a82a81 has been approved by steveklabnik

@bors

bors commented Apr 7, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5a82a81 with merge b41f2df...

bors added a commit that referenced this pull request Apr 7, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 7, 2015
@bors

bors commented Apr 7, 2015

Copy link
Copy Markdown
Collaborator

@bors bors merged commit 5a82a81 into rust-lang:master Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants