Use 'in' instead of 'find()' in tidy.py#21377
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 21, 2015
iKevinY:speedy-tidy
Merged
Use 'in' instead of 'find()' in tidy.py#21377bors merged 1 commit intorust-lang:masterfrom iKevinY:speedy-tidy
bors merged 1 commit intorust-lang:masterfrom
iKevinY:speedy-tidy
Conversation
'x in y' is more Pythonic and faster than 'y.find(x) != -1'.
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 19, 2015
`x in y` is more Pythonic than `y.find(x) != -1`. I believe it runs quite a bit faster as well (though it's probably not a bottleneck of the Travis builds):
```bash
$ python -m timeit '"abc".find("a") != -1'
1000000 loops, best of 3: 0.218 usec per loop
$ python -m timeit '"a" in "abc"'
10000000 loops, best of 3: 0.0343 usec per loop
```
barosl
added a commit
to barosl/rust
that referenced
this pull request
Jan 20, 2015
`x in y` is more Pythonic than `y.find(x) != -1`. I believe it runs quite a bit faster as well (though it's probably not a bottleneck of the Travis builds):
```bash
$ python -m timeit '"abc".find("a") != -1'
1000000 loops, best of 3: 0.218 usec per loop
$ python -m timeit '"a" in "abc"'
10000000 loops, best of 3: 0.0343 usec per loop
```
Kobzol
pushed a commit
to Kobzol/rust
that referenced
this pull request
Jan 5, 2026
…e-proc-macro-bidirectional-flow proc-macro-srv: support file and local_file via bidirectional callbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x in yis more Pythonic thany.find(x) != -1. I believe it runs quite a bit faster as well (though it's probably not a bottleneck of the Travis builds):