Remove duplicate code by using util::copy() #19016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. |
Member
|
This isn't quite identical due to the call to |
Contributor
Author
|
Sorry, for the mistake. I'll look into using update_err |
Contributor
Author
|
Updated to conform with err style |
Member
|
Looks like this may have picked up some extra files! |
Contributor
Author
|
Yes, dealing with them :( |
Contributor
Author
|
Should be fixed now. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 27, 2025
fix: Fix `ItemScope` not recording glob imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is identical to io::util::copy()