libgraphviz: Id::new returns Result<Id, ()> instead of panicking on error #18921
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. |
|
sorry, didn't know about |
oli-obk
force-pushed
the
refactoring/graphviz/id/new/result_instead_of_fail
branch
from
0798273 to
f4ba7ee
Compare
src/libgraphviz/lib.rs
Outdated
There was a problem hiding this comment.
Could you update the documentation of this function to include the error cases as well? It's not totally clear when Err would be returned for example.
oli-obk
force-pushed
the
refactoring/graphviz/id/new/result_instead_of_fail
branch
from
f4ba7ee to
6221f7e
Compare
src/libgraphviz/lib.rs
Outdated
There was a problem hiding this comment.
@alexcrichton like this or should i create an example?
oli-obk
force-pushed
the
refactoring/graphviz/id/new/result_instead_of_fail
branch
from
6221f7e to
d0edf59
Compare
oli-obk
force-pushed
the
refactoring/graphviz/id/new/result_instead_of_fail
branch
5 times, most recently
from
abbc1cc to
9c06cb7
Compare
…rror creating a new Id object requires the format to match a subset of `ID` format defined by the DOT language. When the format did not match, the function called assert. This was not mentioned in the docs or the spec. I made the failure explicit by returning an Result<Id, ()>.
oli-obk
force-pushed
the
refactoring/graphviz/id/new/result_instead_of_fail
branch
from
9c06cb7 to
70bf4f7
Compare
|
the tests are now two separate tests (and they compile). |
|
Thanks @oli-obk! |
oli-obk
deleted the
refactoring/graphviz/id/new/result_instead_of_fail
branch
internal: Compute inlay hint text edits lazily
5 participants
creating a new Id object requires the format to match a subset of
IDformat defined by the DOT language. When the format did not match, the function called assert. This was not mentioned in the docs or the spec. I made the failure explicit by returning an Result<Id, ()>.