mk: Fix configuration of version commit information #18846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit bec2ee7 started quoting paths discovered as part of the `probe` function, which includes git. The `make` `wildcard` function appears to be incompatible with quoted paths so this check in the makefile now fails. Employing `wildcard` here appears to only re-verify that git actually exists, which the configure script already did, so I've just removed it. Additionally, with the quoted paths the `subst` function should no longer be needed, so I've removed it as well. Closes rust-lang#18771
Contributor
Author
|
Closing. We're going to revert bec2ee7 instead. It also caused http://buildbot.rust-lang.org/builders/nightly-win-32/builds/57/steps/distcheck/logs/stdio. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 7, 2025
minor: New clippy lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit bec2ee7 started quoting paths
discovered as part of the
probefunction, which includes git. Themakewildcardfunction appears to be incompatible with quotedpaths so this check in the makefile now fails. Employing
wildcardhere appears to only re-verify that git actually exists, which the
configure script already did, so I've just removed it.
Additionally, with the quoted paths the
substfunction should nolonger be needed, so I've removed it as well.
Closes #18771