Skip to content

First stage of struct variant field visibility changes #18792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Nov 10, 2014
Merged

First stage of struct variant field visibility changes #18792

bors merged 1 commit into from
Nov 10, 2014

Conversation

@sfackler
Copy link
Member

@sfackler sfackler commented Nov 9, 2014

We need a snapshot before the parser can be adjusted.

@alexcrichton
Copy link
Member

alexcrichton commented Nov 9, 2014

r=me with two more tests (or r+ now if they already exist):

  • Some compiler error should happen with pub struct variant fields
  • Some test which ensures that private fields cannot be accessed across modules or across crates if they're private (just some error to make sure it's denied)

@sfackler
Copy link
Member Author

sfackler commented Nov 9, 2014

pub is still accepted, since the new visibility behavior needs to be staged before the parser can be adjusted.

@sfackler
First stage of struct variant field visibility changes
00741a2 
We need a snapshot before the parser can be adjusted.
bors added a commit that referenced this pull request Nov 10, 2014
@bors
auto merge of #18792 : sfackler/rust/struct-variants, r=alexcrichton
221115c 
We need a snapshot before the parser can be adjusted.
@bors bors closed this Nov 10, 2014
@bors bors merged commit 00741a2 into rust-lang:master Nov 10, 2014
@sfackler sfackler deleted the struct-variants branch November 26, 2016 05:54
lnicola pushed a commit to lnicola/rust that referenced this pull request Jan 7, 2025
@Veykril
Merge pull request rust-lang#18792 from Veykril/push-wonkvzozmmwz
4a1c7d1 
Decouple proc-macro server protocol from the server implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfackler @alexcrichton @bors