Doc: Updates a little the make tips message #18399
Conversation
The link to the more detailed tour of rustc, is not a link to the repo so I don't know if it's ok, but it's the closest to the idea of a build suite I could find. Closes rust-lang#17950
|
I'm concerned about linking to someone's blog over something we control. |
|
Another solution is to give a link to https://github.com/rust-lang/rust/wiki/Note-rustc-hacking-guide, which is the closest thing we have to an explanation of the build system (the lack of this might be the real issue). |
|
It maybe worth contacting @thomaslee to see whether the post can/cannot be converted to markdown and committed to the repo if that's really the best we have on the build system right now. |
|
Well if @thomaslee is ok with it, I can even try to convert this to markdown. |
|
Go for it. Some sort of attribution would be nice, but I'm not precious -- the contents of the post are yours to do as you will, Mozillians. :) |
|
Oh and I use Octopress so I may have the markdown handy, will check tonight. |
|
Awesome ! |
|
Alrighty, here's the raw markdown: https://gist.githubusercontent.com/thomaslee/fb946b22c5de64bf64a6/raw/e678086df65fd5946c2eb3ffd3079c25f50561cf/gistfile1.md Rendering is a little quirky in places because of github's markdown variant playing games: https://gist.github.com/thomaslee/fb946b22c5de64bf64a6 @gamazeps if you want to polish this up for a PR or whatever, it's all yours -- otherwise I can get around to it over the next few weeks. |
|
Oh and thanks for the kind words. Glad it was helpful. :) |
|
I think trashing this PR and putting your markdown file (with attribution) in the wiki would be the best solution. |
|
@gamazeps As @thomaslee seems to be on board, I think it's up to @steveklabnik to have the final word on this, but why would you trash this PR? |
|
There already is a link in the original code, to the Notes-build-system wiki page (which is currently empty), filling this page with the content provided by @thomaslee seems to be the best thing to do to me (no need to change code, so no PR). Otherwise we could link to a page called Notes-rustc-tour (in reference to the original article). I'm assuming no PR is needed to change the wiki, is that correct ? |
|
I don't particularly like the wiki, but I think for now it's the best place we have for something like this. I agree that we shouldn't embed it into the Rust repo itself. |
|
Closing due to inactivity, but feel free to reopen with comments addressed! |
…qkmv Fix diagnostic enable config being ignored
6 participants
The link to the more detailed tour of rustc, is not a link to the repo
so I don't know if it's ok, but it's the closest to the idea of a build
suite I could find.
Another solution might be to complete the link in the wiki, but I'm not familiar enough with the build suite to do that :/
Closes #17950