Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata by dpaoliello · Pull Request #159781 · rust-lang/rust

dpaoliello · 2026-07-23T16:29:48Z

The recent Cargo submodule update picked up rust-lang/cargo#17149

However, bootstrap was still using the old name, resulting in:

Building stage1 library artifacts (stage1 -> stage1, arm64ec-pc-windows-msvc)
error: unknown `-Z` flag specified: no-embed-metadata

Fix is to switch to the rename.

I also removed the diff in the Cranelift setup script, since they must have already hit this issue and no longer need the workaround.

rustbot · 2026-07-23T16:29:51Z

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

rustbot · 2026-07-23T16:29:54Z

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 74 candidates
Random selection from 20 candidates

Kobzol · 2026-07-23T16:40:53Z

Ah, this is annoying. On stage0/beta Cargo, the old flag is still used, while if we use the in-tree stage1+ Cargo, we have to use the new flag.

Kobzol · 2026-07-23T16:41:36Z

Maybe we can just temporarily stop using this flag, although I'm not sure whether bootstrap can deal with both the flag being on and off.

bjorn3 · 2026-07-23T16:42:58Z

We can check for the local-rebuild config, right? If that is set, the new cli flag should be used, otherwise the old cli flag.

bjorn3 · 2026-07-23T17:08:16Z

        if matches!(mode, Mode::Std) {
-            cargo.arg("-Zembed-metadata=no");
+            // The `-Zembed-metadata` flag was renamed from `-Zno-embed-metadata`.
+            if build_compiler_stage == 0 {


The same cargo is used for all stages, so checking build_compiler_stage is not correct. local-rebuild should work though. That is what is used to indicate that the bootstrap toolchain (and thus cargo) matches the in-tree one (or is at most a patch release away)

View changes since the review

…adata The recent Cargo submodule update picked up <rust-lang/cargo#17149> However, bootstrap was still using the old name, resulting in: ``` Building stage1 library artifacts (stage1 -> stage1, arm64ec-pc-windows-msvc) error: unknown `-Z` flag specified: no-embed-metadata ``` Fix is to switch to the rename. I also removed the diff in the Cranelift setup script, since they must have already hit this issue and no longer need the workaround.

Kobzol · 2026-07-23T20:27:59Z

Thank you! Let's try.

@bors r+ rollup=iffy

rust-bors · 2026-07-23T20:28:03Z

📌 Commit fe37a8a has been approved by Kobzol

It is now in the queue for this repository.

Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata The recent Cargo submodule update picked up <rust-lang/cargo#17149> However, bootstrap was still using the old name, resulting in: ``` Building stage1 library artifacts (stage1 -> stage1, arm64ec-pc-windows-msvc) error: unknown `-Z` flag specified: no-embed-metadata ``` Fix is to switch to the rename. I also removed the diff in the Cranelift setup script, since they must have already hit this issue and no longer need the workaround.

dpaoliello · 2026-07-24T01:40:47Z

Just validated that this change fixes our internal pipeline as well!

Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata The recent Cargo submodule update picked up <rust-lang/cargo#17149> However, bootstrap was still using the old name, resulting in: ``` Building stage1 library artifacts (stage1 -> stage1, arm64ec-pc-windows-msvc) error: unknown `-Z` flag specified: no-embed-metadata ``` Fix is to switch to the rename. I also removed the diff in the Cranelift setup script, since they must have already hit this issue and no longer need the workaround.

Rollup of 12 pull requests Successful merges: - #159765 (Avoid spurious rebuilds of JSON docs in bootstrap) - #159781 (Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata) - #158362 (trait solver: account for universes from replace_bound_vars) - #159173 (Add allowed list check on EII implementations attributes) - #159718 (Make `DocLinkResMap` an `FxIndexMap`) - #159722 ( [rustdoc] Retrieve `cfg_attr` information for derived impls for `doc_cfg` feature) - #155795 (constify `vec![1, 2, 3]` macro) - #157776 (ci: Enable autodiff tests on x86_64 linux) - #158766 (Promote riscv64-unknown-linux-musl to tier 2 with host tools) - #159271 (str: add ASCII fast path to word_to_titlecase) - #159666 (fix(ld64.lld): route version mismatch warnings to linker_info on macOS) - #159667 (Make some parser structured suggestions verbose and tweak their wording)

Rollup of 14 pull requests Successful merges: - #159765 (Avoid spurious rebuilds of JSON docs in bootstrap) - #159781 (Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata) - #158362 (trait solver: account for universes from replace_bound_vars) - #158372 (rustfmt: Discover modules via `cfg_select!`) - #159173 (Add allowed list check on EII implementations attributes) - #159718 (Make `DocLinkResMap` an `FxIndexMap`) - #159722 ( [rustdoc] Retrieve `cfg_attr` information for derived impls for `doc_cfg` feature) - #159731 (std: Implement futex on wasip3 targets, update target spec) - #159755 (Improve consistency of attribute error messages) - #155795 (constify `vec![1, 2, 3]` macro) - #157776 (ci: Enable autodiff tests on x86_64 linux) - #158766 (Promote riscv64-unknown-linux-musl to tier 2 with host tools) - #159271 (str: add ASCII fast path to word_to_titlecase) - #159667 (Make some parser structured suggestions verbose and tweak their wording)

Rollup merge of #159781 - dpaoliello:noembed, r=Kobzol Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata The recent Cargo submodule update picked up <rust-lang/cargo#17149> However, bootstrap was still using the old name, resulting in: ``` Building stage1 library artifacts (stage1 -> stage1, arm64ec-pc-windows-msvc) error: unknown `-Z` flag specified: no-embed-metadata ``` Fix is to switch to the rename. I also removed the diff in the Cranelift setup script, since they must have already hit this issue and no longer need the workaround.

Rollup of 14 pull requests Successful merges: - rust-lang/rust#159765 (Avoid spurious rebuilds of JSON docs in bootstrap) - rust-lang/rust#159781 (Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata) - rust-lang/rust#158362 (trait solver: account for universes from replace_bound_vars) - rust-lang/rust#158372 (rustfmt: Discover modules via `cfg_select!`) - rust-lang/rust#159173 (Add allowed list check on EII implementations attributes) - rust-lang/rust#159718 (Make `DocLinkResMap` an `FxIndexMap`) - rust-lang/rust#159722 ( [rustdoc] Retrieve `cfg_attr` information for derived impls for `doc_cfg` feature) - rust-lang/rust#159731 (std: Implement futex on wasip3 targets, update target spec) - rust-lang/rust#159755 (Improve consistency of attribute error messages) - rust-lang/rust#155795 (constify `vec![1, 2, 3]` macro) - rust-lang/rust#157776 (ci: Enable autodiff tests on x86_64 linux) - rust-lang/rust#158766 (Promote riscv64-unknown-linux-musl to tier 2 with host tools) - rust-lang/rust#159271 (str: add ASCII fast path to word_to_titlecase) - rust-lang/rust#159667 (Make some parser structured suggestions verbose and tweak their wording)

rustbot assigned mejrs Jul 23, 2026

This comment has been minimized.

Sign in to view

bjorn3 reviewed Jul 23, 2026

View reviewed changes

dpaoliello force-pushed the noembed branch from 61225d0 to fe37a8a Compare July 23, 2026 18:11

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2026

jhpratt mentioned this pull request Jul 23, 2026

Rollup of 11 pull requests #159803

Closed

jhpratt mentioned this pull request Jul 24, 2026

Rollup of 12 pull requests #159806

Closed

jhpratt mentioned this pull request Jul 24, 2026

Rollup of 12 pull requests #159807

Closed

jhpratt mentioned this pull request Jul 24, 2026

Rollup of 14 pull requests #159814

Merged

rust-bors Bot merged commit 5e46148 into rust-lang:main Jul 24, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 24, 2026

dpaoliello deleted the noembed branch July 24, 2026 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata#159781

Update bootstrap to use -Zembed-metadata=no instead of -Zno-embed-metadata#159781
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
dpaoliello:noembed

dpaoliello commented Jul 23, 2026

Uh oh!

rustbot commented Jul 23, 2026

Uh oh!

rustbot commented Jul 23, 2026

Uh oh!

This comment has been minimized.

Kobzol commented Jul 23, 2026

Uh oh!

Kobzol commented Jul 23, 2026

Uh oh!

bjorn3 commented Jul 23, 2026

Uh oh!

This comment has been minimized.

bjorn3 Jul 23, 2026 •

edited by rustbot

Loading

Uh oh!

Kobzol commented Jul 23, 2026

Uh oh!

rust-bors Bot commented Jul 23, 2026

Uh oh!

dpaoliello commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

dpaoliello commented Jul 23, 2026

Uh oh!

rustbot commented Jul 23, 2026

Uh oh!

rustbot commented Jul 23, 2026

Uh oh!

This comment has been minimized.

Kobzol commented Jul 23, 2026

Uh oh!

Kobzol commented Jul 23, 2026

Uh oh!

bjorn3 commented Jul 23, 2026

Uh oh!

This comment has been minimized.

bjorn3 Jul 23, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kobzol commented Jul 23, 2026

Uh oh!

rust-bors Bot commented Jul 23, 2026

Uh oh!

dpaoliello commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bjorn3 Jul 23, 2026 •

edited by rustbot

Loading