Remove outdated workaround for P type#159773
Merged
Merged
Conversation
P is long gone, so this workaround is no longer necessary
rustbot
added
S-waiting-on-review
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use Why was this reviewer chosen?The reviewer was selected based on:
|
panstromek
changed the title
P typeP type
Member
|
nice! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 24, 2026
Rollup of 20 pull requests Successful merges: - #150161 (Remove 'static requirement on try_as_dyn) - #159412 (Reorganize `tests/ui/issues` [26/N]) - #159466 (cmse: clear variant-dependent padding in `enum`s) - #157905 (Update comments and add tests for `-Zrandomize-layout` for some guaranteed ZSTs) - #158479 (Reject static item as direct const generic arg) - #159041 (Reorganize `tests/ui/issues` [22/N]) - #159108 (Reorganize `tests/ui/issues` [23/N]) - #159138 (doc: document wasm import symbol mangling) - #159531 (Reorganize `tests/ui/issues` [28/N]) - #159608 (early_otherwise: Don't hoist dereferences when the otherwise branch is reachable) - #159612 (Reorganize `tests/ui/issues` [29/N]) - #159653 (run `tests/assembly-llvm/asm/aarch64-types.rs` for `aarch64_be`) - #159719 (tests: add UI test for `.swap()` suggestion) - #159737 (rustfmt fix: allow file not found errors for external mods annotated with `#[my_macro]`) - #159759 (rustc-dev-guide subtree update) - #159761 (Remove outdated comment for resolve_vars_with_obligations) - #159764 (use `minicore::simd::Simd` more) - #159773 (Remove outdated workaround for `P` type) - #159778 (use lowest edition the test accepts) - #159788 (Avoid ICEing in RPIT method chain suggestion)
rust-timer
added a commit
that referenced
this pull request
Jul 24, 2026
Rollup merge of #159773 - panstromek:remove-p-workaround, r=fee1-dead Remove outdated workaround for `P` type P is long gone, so this workaround is no longer necessary. The workaround took attrs out of node, inspected and possibly modified it and then put it back at the end of each branch of the following match.
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jul 25, 2026
Rollup of 20 pull requests Successful merges: - rust-lang/rust#150161 (Remove 'static requirement on try_as_dyn) - rust-lang/rust#159412 (Reorganize `tests/ui/issues` [26/N]) - rust-lang/rust#159466 (cmse: clear variant-dependent padding in `enum`s) - rust-lang/rust#157905 (Update comments and add tests for `-Zrandomize-layout` for some guaranteed ZSTs) - rust-lang/rust#158479 (Reject static item as direct const generic arg) - rust-lang/rust#159041 (Reorganize `tests/ui/issues` [22/N]) - rust-lang/rust#159108 (Reorganize `tests/ui/issues` [23/N]) - rust-lang/rust#159138 (doc: document wasm import symbol mangling) - rust-lang/rust#159531 (Reorganize `tests/ui/issues` [28/N]) - rust-lang/rust#159608 (early_otherwise: Don't hoist dereferences when the otherwise branch is reachable) - rust-lang/rust#159612 (Reorganize `tests/ui/issues` [29/N]) - rust-lang/rust#159653 (run `tests/assembly-llvm/asm/aarch64-types.rs` for `aarch64_be`) - rust-lang/rust#159719 (tests: add UI test for `.swap()` suggestion) - rust-lang/rust#159737 (rustfmt fix: allow file not found errors for external mods annotated with `#[my_macro]`) - rust-lang/rust#159759 (rustc-dev-guide subtree update) - rust-lang/rust#159761 (Remove outdated comment for resolve_vars_with_obligations) - rust-lang/rust#159764 (use `minicore::simd::Simd` more) - rust-lang/rust#159773 (Remove outdated workaround for `P` type) - rust-lang/rust#159778 (use lowest edition the test accepts) - rust-lang/rust#159788 (Avoid ICEing in RPIT method chain suggestion)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P is long gone, so this workaround is no longer necessary.
The workaround took attrs out of node, inspected and possibly modified it and then put it back at the end of each branch of the following match.