Skip to content

Split set_alloc_error_hook#159702

Draft
nia-e wants to merge 4 commits into
rust-lang:mainfrom
nia-e:alloc-error-unwind-hook
Draft

Split set_alloc_error_hook#159702
nia-e wants to merge 4 commits into
rust-lang:mainfrom
nia-e:alloc-error-unwind-hook

Conversation

@nia-e

@nia-e nia-e commented Jul 22, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Per libs-api consensus in rust-lang/libs-team#834; modifies #51245.

r? libs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 22, 2026
@nia-e nia-e added A-allocators Area: Custom and system allocators T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 22, 2026
jhpratt
jhpratt reviewed Jul 22, 2026
View reviewed changes
Comment thread library/std/src/alloc.rs Outdated
dtolnay
dtolnay requested changes Jul 22, 2026
View reviewed changes
Comment thread library/std/src/alloc.rs Outdated
Comment thread library/std/src/alloc.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2026
@jhpratt

jhpratt commented Jul 22, 2026

Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

🔨 2 commits were squashed into 649e2f3.

@rust-bors
rust-bors Bot force-pushed the alloc-error-unwind-hook branch from 224949f to 649e2f3 Compare July 22, 2026 05:00
@jhpratt

jhpratt commented Jul 22, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 649e2f3 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026
@nia-e

nia-e commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

🦫

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jhpratt

jhpratt commented Jul 22, 2026

Copy link
Copy Markdown
Member

@bors r-

@bors delegate+

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 22, 2026
@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 22, 2026
@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

✌️ @nia-e, you can now approve this pull request!

If @jhpratt told you to "r=me" after making some further change, then please make that change and post @bors r=jhpratt.

View changes since this delegation.

@nia-e
nia-e force-pushed the alloc-error-unwind-hook branch 2 times, most recently from a2ab508 to 8e3cc4e Compare July 22, 2026 05:49
@nia-e

nia-e commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

passed locally.

@bors r=jhpratt rollup

@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8e3cc4e has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026
@nia-e
nia-e force-pushed the alloc-error-unwind-hook branch from 8e3cc4e to 1cf8cce Compare July 22, 2026 06:36
@rustbot

This comment was marked as off-topic.

Sign in to view
@nia-e

nia-e commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

@bors r=jhpratt rollup

@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1cf8cce has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026
RalfJung
RalfJung reviewed Jul 22, 2026
View reviewed changes
Comment thread library/std/src/alloc.rs
RalfJung
RalfJung reviewed Jul 22, 2026
View reviewed changes
Comment thread library/std/src/alloc.rs
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159702 - nia-e:alloc-error-unwind-hook, r=j…
dc96a8a 
…hpratt

Split `set_alloc_error_hook`

Per libs-api consensus in rust-lang/libs-team#834; modifies rust-lang#51245.

r? libs
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 22, 2026
Closed
@RalfJung RalfJung mentioned this pull request Jul 22, 2026
Open
5 tasks
@nia-e

nia-e commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

one more rejection, docs need changing. sorry jonathan :<

@bors r-

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2026
@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#159709), which was unapproved.

View changes since this unapproval

@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

⚠️ A new commit 8071b7d9cb6abcc481c40669871dd00eced2ac56 was pushed.

This PR was contained in a rollup (#159709), which was closed.

RalfJung
RalfJung reviewed Jul 22, 2026
View reviewed changes
Comment thread library/std/src/alloc.rs Outdated
RalfJung
RalfJung reviewed Jul 22, 2026
View reviewed changes
Comment thread library/std/src/alloc.rs
@nia-e nia-e added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Jul 22, 2026
nia-e
nia-e commented Jul 22, 2026
View reviewed changes
Comment thread library/alloc/src/alloc.rs
/// configuration for all panics), or abort the process (with no unwinding).
/// Callers may assume that this function always aborts execution. However, implementors that do not
/// rely on this invariant are encouraged to document this in order to be compatible with users of
/// [`set_alloc_error_hook_unwinding`].

@nia-e nia-e Jul 22, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @rust-lang/libs-api - this does need fcp after all (see discussion on zulip)

View changes since the review

This comment was marked as resolved.

Sign in to view

@RalfJung RalfJung Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxdexh correctly points out that this tells clients of the global allocator to call handle_alloc_error, not global allocators themselves. Sorry for the noise.

@nia-e

This comment was marked as outdated.

Sign in to view
@nia-e nia-e added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026
@nia-e

nia-e commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

wow this turned out to be controversial. i'll let this bake for a bit i guess since it seems to be a bit broader than just a team nomination

@nia-e
nia-e marked this pull request as draft July 22, 2026 11:33
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 22, 2026
@RalfJung RalfJung mentioned this pull request Jul 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJung RalfJung RalfJung left review comments
@jhpratt jhpratt jhpratt left review comments
@bjorn3 bjorn3 bjorn3 left review comments
@dtolnay dtolnay dtolnay requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jhpratt jhpratt

Labels

A-allocators Area: Custom and system allocators needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nia-e @jhpratt @rust-log-analyzer @rustbot @RalfJung @dtolnay @bjorn3