Split non-local semicolon_in_expressions_from_macros into a separate lint#159700
Split non-local semicolon_in_expressions_from_macros into a separate lint#159700joshtriplett wants to merge 2 commits into
semicolon_in_expressions_from_macros into a separate lint#159700Conversation
joshtriplett
added
A-macros
rustbot
added
S-waiting-on-review
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Needs lang approval for the new lint. Hoping to get that approval in tomorrow's (2026-07-22) lang meeting. This is needed due to many new errors in the ecosystem; we need to give people time to fix those, and not (effectively) go directly from not emitting a lint at all to emitting a deny-by-default lint. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…e lint The new handling for non-local macros in `semicolon_in_expressions_from_macros` produces new deny-by-default lints on various existing crates, which have not previously received warnings because prior Rust versions suppressed them. Split those out into a new `semicolon_in_expressions_from_non_local_macros` lint, and make that one warn-by-default (and FCW warn-in-deps), rather than deny-by-default, to give the ecosystem time to adapt. This reintroduces the `is_local` tracking from commit 9192337.
…ros` The automatic mechanism to produce lint examples won't work, since this lint needs a separate crate, so add a `rust,ignore` example and manually provide the compiler output.
d35b967 to
c1a4b72
Compare
traviscross
added
the
P-lang-drag-0
petrochenkov
added
S-waiting-on-t-lang
|
Proposed to accept this and waive any part of our 10-day FCP period necessary to get this into the next release. @rfcbot fcp merge lang |
|
@traviscross has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
rust-rfcbot
added
proposed-final-comment-period
|
@rfcbot reviewed |
1 similar comment
|
@rfcbot reviewed |
rust-rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
joshtriplett
added
S-waiting-on-review
|
@bors r+ |
|
📋 This PR cannot be approved because it currently has the following label: |
|
Ah, wrong label, still waiting on lang fcp. |
petrochenkov
added
S-waiting-on-fcp
|
@petrochenkov We have five out of five checkboxes, and an explicitly waived 10-day period. Let's go ahead and merge this; it's easy enough to revert if the situation changes. |
9 participants
The new handling for non-local macros in
semicolon_in_expressions_from_macrosproduces new deny-by-defaultlints on various existing crates, which have not previously received
warnings because prior Rust versions suppressed them. Split those out
into a new
semicolon_in_expressions_from_non_local_macroslint, andmake that one warn-by-default (and FCW warn-in-deps), rather than
deny-by-default, to give the ecosystem time to adapt.
This reintroduces the
is_localtracking from commit9192337.