define a Simd type in minicore#159656
Merged
Merged
Conversation
folkertdev
commented
Jul 21, 2026
Comment on lines
+32
to
+33
| type i32x5 = Simd<i32, 5>; | ||
| type f32x5 = Simd<f32, 5>; |
Contributor
Author
There was a problem hiding this comment.
non-standard (so not a power of 2) types I've left as type aliases in specific tests.
Comment on lines
+19
to
+20
| type i32x32 = Simd<i32, 32>; // 1024-bit HVX vector (128B mode) | ||
| type i32x64 = Simd<i32, 64>; // 2048-bit HVX vector pair (128B mode) |
Contributor
Author
There was a problem hiding this comment.
and here the types have specific comments, so I've left them as type aliases here rather than importing.
jieyouxu
approved these changes
Jul 21, 2026
Contributor
Author
|
@bors r+ |
Contributor
Contributor
Author
Contributor
|
This pull request was unapproved. |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 21, 2026
define a `Simd` type in `minicore` Saves a lot of repetition. r? jieyouxu
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 21, 2026
define a `Simd` type in `minicore` Saves a lot of repetition. r? jieyouxu
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 21, 2026
define a `Simd` type in `minicore` Saves a lot of repetition. r? jieyouxu
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 21, 2026
Rollup of 12 pull requests Successful merges: - #159582 (Sync from portable simd 2026 07 20) - #158890 (Fix splat v0 mangling) - #159411 ([rustdoc] Correctly handle output options with --show-coverage) - #159647 (Remove `early_exit` closures) - #159656 (define a `Simd` type in `minicore`) - #156474 (Add paths for linked associated items) - #159211 (Fix debuginfo argument when invoking LLBC linker) - #159527 (Bring runtime symbols statics on par with foreign functions) - #159625 (Refactor is_opsem_inhabited) - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - #159663 (Add layout cycle hang regression test)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 22, 2026
define a `Simd` type in `minicore` Saves a lot of repetition. r? jieyouxu
This was referenced Jul 22, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 22, 2026
Rollup of 13 pull requests Successful merges: - #159582 (Sync from portable simd 2026 07 20) - #158890 (Fix splat v0 mangling) - #159614 (debuginfo generation for unsafe binders) - #159647 (Remove `early_exit` closures) - #159656 (define a `Simd` type in `minicore`) - #156474 (Add paths for linked associated items) - #159211 (Fix debuginfo argument when invoking LLBC linker) - #159527 (Bring runtime symbols statics on par with foreign functions) - #159625 (Refactor is_opsem_inhabited) - #159629 (Add more splat rust-call regression tests) - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - #159663 (Add layout cycle hang regression test)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 22, 2026
Rollup of 13 pull requests Successful merges: - #159582 (Sync from portable simd 2026 07 20) - #158890 (Fix splat v0 mangling) - #159614 (debuginfo generation for unsafe binders) - #159647 (Remove `early_exit` closures) - #159656 (define a `Simd` type in `minicore`) - #156474 (Add paths for linked associated items) - #159211 (Fix debuginfo argument when invoking LLBC linker) - #159527 (Bring runtime symbols statics on par with foreign functions) - #159625 (Refactor is_opsem_inhabited) - #159629 (Add more splat rust-call regression tests) - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - #159663 (Add layout cycle hang regression test)
rust-timer
added a commit
that referenced
this pull request
Jul 22, 2026
Rollup merge of #159656 - folkertdev:minicore-simd, r=jieyouxu define a `Simd` type in `minicore` Saves a lot of repetition. r? jieyouxu
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jul 22, 2026
Rollup of 13 pull requests Successful merges: - rust-lang/rust#159582 (Sync from portable simd 2026 07 20) - rust-lang/rust#158890 (Fix splat v0 mangling) - rust-lang/rust#159614 (debuginfo generation for unsafe binders) - rust-lang/rust#159647 (Remove `early_exit` closures) - rust-lang/rust#159656 (define a `Simd` type in `minicore`) - rust-lang/rust#156474 (Add paths for linked associated items) - rust-lang/rust#159211 (Fix debuginfo argument when invoking LLBC linker) - rust-lang/rust#159527 (Bring runtime symbols statics on par with foreign functions) - rust-lang/rust#159625 (Refactor is_opsem_inhabited) - rust-lang/rust#159629 (Add more splat rust-call regression tests) - rust-lang/rust#159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - rust-lang/rust#159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - rust-lang/rust#159663 (Add layout cycle hang regression test)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 23, 2026
…eyouxu use `minicore::simd::Simd` more follow-up to rust-lang#159656. I've used `grep -rlZ "repr_simd" . | xargs -0 grep -l "use minicore"` to find all test files that used both `repr_simd` and `use minicore`, they now all use `minicore::simd` to `repr_simd` is no longer needed for them.
rust-timer
added a commit
that referenced
this pull request
Jul 24, 2026
Rollup merge of #159764 - folkertdev:use-minicore-simd, r=jieyouxu use `minicore::simd::Simd` more follow-up to #159656. I've used `grep -rlZ "repr_simd" . | xargs -0 grep -l "use minicore"` to find all test files that used both `repr_simd` and `use minicore`, they now all use `minicore::simd` to `repr_simd` is no longer needed for them.
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jul 25, 2026
use `minicore::simd::Simd` more follow-up to rust-lang/rust#159656. I've used `grep -rlZ "repr_simd" . | xargs -0 grep -l "use minicore"` to find all test files that used both `repr_simd` and `use minicore`, they now all use `minicore::simd` to `repr_simd` is no longer needed for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saves a lot of repetition.
r? jieyouxu