Fix string indexing in diagnostic format strings by mejrs · Pull Request #159470 · rust-lang/rust

mejrs · 2026-07-17T22:05:25Z

This also affects beta.

rustbot · 2026-07-17T22:05:29Z

rustbot has assigned @ShoyuVanilla.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 74 candidates
Random selection from 17 candidates

jieyouxu

Thanks
? me @bors r+ rollup

View changes since this review

rust-bors · 2026-07-18T05:09:34Z

📌 Commit d61c706 has been approved by jieyouxu

It is now in the queue for this repository.

Fix string indexing in diagnostic format strings Fixes rust-lang#159252 This also affects beta.

…uwer Rollup of 5 pull requests Successful merges: - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #158545 (Move `std::io::read_to_string` to `alloc::io`) - #159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test) - #159470 (Fix string indexing in diagnostic format strings) - #159500 (Move compiletest CLI parsing to `cli.rs`)

Fix string indexing in diagnostic format strings Fixes rust-lang#159252 This also affects beta.

…uwer Rollup of 5 pull requests Successful merges: - #159467 (Add explicit `Iterator::count` impl for `str::EncodeUtf16`) - #158545 (Move `std::io::read_to_string` to `alloc::io`) - #159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test) - #159470 (Fix string indexing in diagnostic format strings) - #159500 (Move compiletest CLI parsing to `cli.rs`)

…uwer Rollup of 8 pull requests Successful merges: - #159425 (Windows: add context when opening NUL for child stdio fails) - #159467 (Add explicit `Iterator::count` impl for `str::EncodeUtf16`) - #157860 (Move rustdoc run-make tests into new `tests/run-make/rustdoc/`) - #158545 (Move `std::io::read_to_string` to `alloc::io`) - #159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test) - #159459 (Detect when trait bound requires closure to return itself) - #159470 (Fix string indexing in diagnostic format strings) - #159500 (Move compiletest CLI parsing to `cli.rs`)

Rollup merge of #159470 - mejrs:fix_diagnostic_ice, r=jieyouxu Fix string indexing in diagnostic format strings Fixes #159252 This also affects beta.

…uwer Rollup of 8 pull requests Successful merges: - rust-lang/rust#159425 (Windows: add context when opening NUL for child stdio fails) - rust-lang/rust#159467 (Add explicit `Iterator::count` impl for `str::EncodeUtf16`) - rust-lang/rust#157860 (Move rustdoc run-make tests into new `tests/run-make/rustdoc/`) - rust-lang/rust#158545 (Move `std::io::read_to_string` to `alloc::io`) - rust-lang/rust#159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test) - rust-lang/rust#159459 (Detect when trait bound requires closure to return itself) - rust-lang/rust#159470 (Fix string indexing in diagnostic format strings) - rust-lang/rust#159500 (Move compiletest CLI parsing to `cli.rs`)

apiraino · 2026-07-20T15:16:33Z

+#[diagnostic::on_unimplemented(note = "🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀{:?}")]
+//~^ERROR positional arguments are not permitted in diagnostic attributes [malformed_diagnostic_format_literals]
+//~|ERROR format specifiers are not permitted in diagnostic attributes [malformed_diagnostic_format_literals]
+pub trait ILoveUnicode {}


rustbot · 2026-07-23T11:29:08Z

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

[beta] backports - Fix string indexing in diagnostic format strings #159470 - Resolver: Record at least 1 ambiguous trait if main decl is not a trait. #159599 - Set the rustc lib path for unstable-book-gen #159613 r? me

Fix string indexing in diagnostic format strings

d61c706

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2026

rustbot assigned ShoyuVanilla Jul 17, 2026

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 17, 2026

mejrs added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 17, 2026

jieyouxu approved these changes Jul 18, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 18, 2026

Rollup merge of rust-lang#159470 - mejrs:fix_diagnostic_ice, r=jieyouxu

e5d06f8

Fix string indexing in diagnostic format strings Fixes rust-lang#159252 This also affects beta.

JonathanBrouwer mentioned this pull request Jul 18, 2026

Rollup of 5 pull requests #159501

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 18, 2026

Rollup merge of rust-lang#159470 - mejrs:fix_diagnostic_ice, r=jieyouxu

d250ce7

Fix string indexing in diagnostic format strings Fixes rust-lang#159252 This also affects beta.

JonathanBrouwer mentioned this pull request Jul 18, 2026

Rollup of 5 pull requests #159510

Closed

JonathanBrouwer mentioned this pull request Jul 18, 2026

Rollup of 8 pull requests #159516

Merged

rust-bors Bot merged commit d711a09 into rust-lang:main Jul 18, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 18, 2026

rust-timer added a commit that referenced this pull request Jul 18, 2026

Unrolled build for #159470

b79eb33

Rollup merge of #159470 - mejrs:fix_diagnostic_ice, r=jieyouxu Fix string indexing in diagnostic format strings Fixes #159252 This also affects beta.

apiraino reviewed Jul 20, 2026

View reviewed changes

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 23, 2026

cuviper mentioned this pull request Jul 23, 2026

[beta] backports #159791

Merged

cuviper modified the milestones: 1.99.0, 1.98.0 Jul 23, 2026

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix string indexing in diagnostic format strings#159470

Fix string indexing in diagnostic format strings#159470
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mejrs:fix_diagnostic_ice

mejrs commented Jul 17, 2026 •

edited

Loading

Uh oh!

rustbot commented Jul 17, 2026

Uh oh!

jieyouxu left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Jul 18, 2026

Uh oh!

Uh oh!

apiraino Jul 20, 2026

Uh oh!

rustbot commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

mejrs commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 17, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jul 18, 2026

Uh oh!

Uh oh!

apiraino Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mejrs commented Jul 17, 2026 •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading