Remove FIXMEs referencing #44232#159360
Merged
Merged
Conversation
These tests, as currently written, make no sense. Relevant functionality is already tested in: * `tests/ui/feature-gates/unknown-feature.rs` * `tests/ui/feature-gates/stable-features.rs` * `tests/ui/lint/unused-features/unused-language-features.rs`
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
theemathas
force-pushed
the
del-44232-comments
branch
from
July 16, 2026 05:08
5963f72 to
4b1bfb5
Compare
|
// Copyright 2013 The Rust Project Developers.
// ... copyright header continues ...
#[deny(unknown_features)];
#[feature(this_is_not_a_feature)]; //~ ERROR: unknown feature
fn main() {}And today it is: //@ check-pass
#![warn(unused_features)]
#![allow(stable_features)]
// FIXME(#44232) we should warn that this isn't used.
fn main() {} |
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jdonszelmann
added a commit
to jdonszelmann/rust
that referenced
this pull request
Jul 16, 2026
…etrochenkov Remove FIXMEs referencing rust-lang#44232 rust-lang#44232 is already closed, since rust-lang#152164 implemented the unused_features lint. The deleted tests, as currently written, make no sense. Relevant functionality is already tested in: * `tests/ui/feature-gates/unknown-feature.rs` * `tests/ui/feature-gates/stable-features.rs` * `tests/ui/lint/unused-features/unused-language-features.rs`
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 16, 2026
…etrochenkov Remove FIXMEs referencing rust-lang#44232 rust-lang#44232 is already closed, since rust-lang#152164 implemented the unused_features lint. The deleted tests, as currently written, make no sense. Relevant functionality is already tested in: * `tests/ui/feature-gates/unknown-feature.rs` * `tests/ui/feature-gates/stable-features.rs` * `tests/ui/lint/unused-features/unused-language-features.rs`
This was referenced Jul 16, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 16, 2026
…uwer Rollup of 18 pull requests Successful merges: - #150679 (dirfd file operations (2/4)) - #158758 (Rename `lazy_type_alias` feature gate to `checked_type_aliases` ) - #159177 (Explicitly materialize debuginfo tests for all debuggers) - #159392 (Update Rust crate rand to v0.9.3 [SECURITY]) - #159393 (Update Rust crate rkyv to v0.8.16 [SECURITY]) - #159394 (Update Rust crate tar to v0.4.46 [SECURITY]) - #159395 (Update Rust crate tracing-subscriber [SECURITY]) - #159193 (Port compiletest's CLI to clap) - #158992 (Shorten types more when only interesting part is lifetimes) - #159226 (Track extra_lifetime_params_map per-owner) - #159273 (tidy: document u64 limit for numeric sort keys) - #159322 (Fix safety doc in intrinsics::simd) - #159329 (Fix the stale metrics directory warning) - #159357 (Add regression tests for two fixed issues) - #159360 (Remove FIXMEs referencing #44232) - #159375 (make a couple codegen-llvm tests compatible with 2021 edition) - #159381 (emit `(lldb)` prefix to make commands more distinct) - #159396 (Update actions/checkout action to v7)
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jul 20, 2026
…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#150679 (dirfd file operations (2/4)) - rust-lang/rust#158758 (Rename `lazy_type_alias` feature gate to `checked_type_aliases` ) - rust-lang/rust#159177 (Explicitly materialize debuginfo tests for all debuggers) - rust-lang/rust#159392 (Update Rust crate rand to v0.9.3 [SECURITY]) - rust-lang/rust#159393 (Update Rust crate rkyv to v0.8.16 [SECURITY]) - rust-lang/rust#159394 (Update Rust crate tar to v0.4.46 [SECURITY]) - rust-lang/rust#159395 (Update Rust crate tracing-subscriber [SECURITY]) - rust-lang/rust#159193 (Port compiletest's CLI to clap) - rust-lang/rust#158992 (Shorten types more when only interesting part is lifetimes) - rust-lang/rust#159226 (Track extra_lifetime_params_map per-owner) - rust-lang/rust#159273 (tidy: document u64 limit for numeric sort keys) - rust-lang/rust#159322 (Fix safety doc in intrinsics::simd) - rust-lang/rust#159329 (Fix the stale metrics directory warning) - rust-lang/rust#159357 (Add regression tests for two fixed issues) - rust-lang/rust#159360 (Remove FIXMEs referencing rust-lang/rust#44232) - rust-lang/rust#159375 (make a couple codegen-llvm tests compatible with 2021 edition) - rust-lang/rust#159381 (emit `(lldb)` prefix to make commands more distinct) - rust-lang/rust#159396 (Update actions/checkout action to v7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#44232 is already closed, since #152164 implemented the unused_features lint.
The deleted tests, as currently written, make no sense. Relevant functionality is already tested in:
tests/ui/feature-gates/unknown-feature.rstests/ui/feature-gates/stable-features.rstests/ui/lint/unused-features/unused-language-features.rs