enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group by hkBst · Pull Request #159179 · rust-lang/rust

hkBst · 2026-07-12T13:28:27Z

This enables the unreachable_cfg_select_predicates lint as part of the unused lint group. This was apparently planned to be enabled as part of cfg_select stabilization, but got overlooked (as can be seen from comments below).

This lint was merged in #149960 which also includes a test for the behavior in tests/ui/macros/cfg_select.rs.

rustbot · 2026-07-12T13:28:32Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 18 candidates

mejrs · 2026-07-12T17:01:44Z

I'm confused, isn't this just adding it to the "unused" lint group? It's been stable since #149783

@folkertdev was this simply forgotten when cfg_select! was stabilized?

folkertdev · 2026-07-12T17:04:23Z

Oh, looks like it yeah. Technically T-lang might have to approve this then?

mejrs · 2026-07-12T18:24:20Z

It looks that way. Is this still something we want?

If so @hkBst can you make a small writeup explaining this change and edit the pr title accordingly, and then nominate it for T-lang?

folkertdev · 2026-07-12T18:30:06Z

I think that we do want this yes. The lint was introduced in #149960, that PR itself deliberately did not go through FCP because the lint was not observable without having the cfg_select feature enabled.

davidtwco

r=me, impl looks good once lang approves

View changes since this review

Since cfg_select is stable since 1.95, this can be enabled.

hkBst · 2026-07-13T12:44:11Z

Thanks to @folkertdev for providing the context (and actually implementing this lint), I was able to improve the PR text and title. So I think this should be good now, @mejrs.

I don't know why this results in one additional copy of an unrelated error being reported in some tests. But since it's already duplicated many times, I guess it is fine.

@rustbot ready

traviscross · 2026-07-14T22:00:20Z

Makes sense. Thanks @hkBst and @folkertdev (and @davidtwco for the review).

@rfcbot fcp merge lang

rust-rfcbot · 2026-07-14T22:00:22Z

@traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

nikomatsakis · 2026-07-15T15:09:01Z

@rfcbot reviewed

rust-rfcbot · 2026-07-15T15:09:08Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rust-rfcbot · 2026-07-25T15:09:47Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

folkertdev · 2026-07-25T15:27:19Z

@bors r=davidtwco

rust-bors · 2026-07-25T15:27:22Z

📌 Commit e91e00f has been approved by davidtwco

It is now in the queue for this repository.

enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group This enables the `unreachable_cfg_select_predicates` lint as part of the `unused` lint group. This was apparently planned to be enabled as part of `cfg_select` stabilization, but got overlooked (as can be seen from comments below). This lint was merged in rust-lang#149960 which also includes a test for the behavior in `tests/ui/macros/cfg_select.rs`.

…uwer Rollup of 25 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159174 (Fix implicit_provenance_casts warnings on Xous) - #159179 (enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group) - #159518 (iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>>) - #159673 (bootstrap: forward -fdebug-prefix-map when using cc) - #159700 (Split non-local `semicolon_in_expressions_from_macros` into a separate lint) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159785 (Share _Unwind_Exception definition between native and wasm) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159204 (Add support to caller_location to rustc_public) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159695 (proc_macro: Fix cfg_attr inner attrs in file modules) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`)

enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group This enables the `unreachable_cfg_select_predicates` lint as part of the `unused` lint group. This was apparently planned to be enabled as part of `cfg_select` stabilization, but got overlooked (as can be seen from comments below). This lint was merged in rust-lang#149960 which also includes a test for the behavior in `tests/ui/macros/cfg_select.rs`.

…uwer Rollup of 25 pull requests Successful merges: - #159825 (codegen: handle OperandValue::Uninit in codegen_return_terminator) - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159174 (Fix implicit_provenance_casts warnings on Xous) - #159179 (enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group) - #159518 (iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>>) - #159673 (bootstrap: forward -fdebug-prefix-map when using cc) - #159700 (Split non-local `semicolon_in_expressions_from_macros` into a separate lint) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159204 (Add support to caller_location to rustc_public) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159695 (proc_macro: Fix cfg_attr inner attrs in file modules) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`)

enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group This enables the `unreachable_cfg_select_predicates` lint as part of the `unused` lint group. This was apparently planned to be enabled as part of `cfg_select` stabilization, but got overlooked (as can be seen from comments below). This lint was merged in rust-lang#149960 which also includes a test for the behavior in `tests/ui/macros/cfg_select.rs`.

rustbot assigned davidtwco Jul 12, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 12, 2026

This comment has been minimized.

Sign in to view

folkertdev added the F-cfg_select `#![feature(cfg_select)]` label Jul 12, 2026

mejrs added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2026

folkertdev added I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy; this does not imply nomination labels Jul 12, 2026

davidtwco approved these changes Jul 13, 2026

View reviewed changes

enable UNREACHABLE_CFG_SELECT_PREDICATES lint

e91e00f

Since cfg_select is stable since 1.95, this can be enabled.

rust-cloud-vms Bot force-pushed the patch-7 branch from 167acea to e91e00f Compare July 13, 2026 12:15

hkBst changed the title ~~enable UNREACHABLE_CFG_SELECT_PREDICATES lint~~ enable unreachable_cfg_select_predicates lint as part of unused lint group Jul 13, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2026

traviscross added P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang T-lang Relevant to the language team labels Jul 14, 2026

rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 14, 2026

rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 15, 2026

rust-rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jul 25, 2026

rust-rfcbot added the to-announce Announce this issue on triage meeting label Jul 25, 2026

rustbot mentioned this pull request Jul 25, 2026

Tracking issue for release notes of #159179: enable unreachable_cfg_select_predicates lint as part of unused lint group #159909

Open

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2026

JonathanBrouwer mentioned this pull request Jul 25, 2026

Rollup of 25 pull requests #159920

Closed

JonathanBrouwer mentioned this pull request Jul 25, 2026

Rollup of 25 pull requests #159926

Closed

jhpratt mentioned this pull request Jul 26, 2026

Rollup of 25 pull requests #159941

Open

Uh oh!

Uh oh!

Conversation

hkBst commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 12, 2026

Uh oh!

This comment has been minimized.

mejrs commented Jul 12, 2026

Uh oh!

folkertdev commented Jul 12, 2026

Uh oh!

mejrs commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

folkertdev commented Jul 12, 2026

Uh oh!

davidtwco left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hkBst commented Jul 13, 2026

Uh oh!

traviscross commented Jul 14, 2026

Uh oh!

rust-rfcbot commented Jul 14, 2026 • edited by tmandry Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nikomatsakis commented Jul 15, 2026

Uh oh!

rust-rfcbot commented Jul 15, 2026

Uh oh!

rust-rfcbot commented Jul 25, 2026

Uh oh!

folkertdev commented Jul 25, 2026

Uh oh!

rust-bors Bot commented Jul 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

hkBst commented Jul 12, 2026 •

edited

Loading

mejrs commented Jul 12, 2026 •

edited

Loading

davidtwco left a comment •

edited by rustbot

Loading

rust-rfcbot commented Jul 14, 2026 •

edited by tmandry

Loading