Fix splat v0 mangling#158890
Conversation
|
rustbot has assigned @hanna-kruppe. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
|
Oops, forgot to implement demangling, I'll get to it tomorrow @rustbobt author |
There was a problem hiding this comment.
Just so you know, changes to the mangling scheme typically also have a corresponding PR to https://github.com/rust-lang/rustc-demangle 🙂
805f25d to
a30c0d8
Compare
a30c0d8 to
afaae5b
Compare
| // FIXME(splat): remove this once splat demangling has been added to rustc | ||
| //@ exec-env: RUST_BACKTRACE=0 |
There was a problem hiding this comment.
Hopefully this should skip demangling in panic backtraces, until the demangling impl in rust-lang/rustc-demangle#90 is added to rustc
@rustbot ready
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Tracking issue: #153629
Typecheck considers a splatted and non-splatted function as distinct types, so mangling has to include splatting. If it doesn't, we get symbol clashes. See the ticket and the tests in this PR for details.
Demangling PR: rust-lang/rustc-demangle#90
@rustbot label +C-bug +F-splat +T-compiler +A-name-mangling
Fixes #158644